refactor: Created generic task scheduling service. #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the expiry service to create a generic task scheduler that may run any generic task on a single instance in an Orb domain cluster. closes trustbloc#891 Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
Codecov Report
@@ Coverage Diff @@
## main #900 +/- ##
==========================================
+ Coverage 89.42% 89.45% +0.03%
==========================================
Files 156 157 +1
Lines 14000 14057 +57
==========================================
+ Hits 12519 12575 +56
+ Misses 912 910 -2
- Partials 569 572 +3
Continue to review full report at Codecov.
|
sandrask
approved these changes
Nov 25, 2021
fqutishat
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the expiry service to create a generic task scheduler that may run any task on a single instance in an Orb domain cluster.
Also created a common utility to start a MongoDB container during unit testing (since this code was copied in multiple places). The Docker container is always started on a unique port to prevent the occasional port conflict error.
closes #891
Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com