feat: MongoDB batch call speed optimization #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRK3
force-pushed
the
MongoDBBatchOptimization
branch
from
b6d8ad1
to
2a02fec
Compare
Codecov Report
@@ Coverage Diff @@
## main #922 +/- ##
==========================================
+ Coverage 89.29% 89.35% +0.05%
==========================================
Files 159 159
Lines 14541 14565 +24
==========================================
+ Hits 12985 13014 +29
+ Misses 954 949 -5
Partials 602 602
Continue to review full report at Codecov.
|
DRK3
force-pushed
the
MongoDBBatchOptimization
branch
from
2a02fec
to
dc98362
Compare
bstasyszyn
reviewed
Dec 6, 2021
| @@ -70,6 +70,8 @@ func (s *Store) Put(anchorID string, witnesses []*proof.Witness) error { | |||
|
|
|||
| anchorIDEncoded := base64.RawURLEncoding.EncodeToString([]byte(anchorID)) | |||
|
|
|||
| putOptions := &storage.PutOptions{IsNewKey: true} | |||
There was a problem hiding this comment.
I don't think we need this here. There will usually only be 2 or 3 items in the batch.
There was a problem hiding this comment.
It'll still be faster and more efficient to use this flag whenever possible. Is there some reason not to?
There was a problem hiding this comment.
Actually, it's fine. I didn't notice that a UUID was used as the key.
DRK3
force-pushed
the
MongoDBBatchOptimization
branch
5 times, most recently
from
6a8616e
to
13ab8ec
Compare
Added an optimization for places that call the store.Batch method using keys that are guaranteed to be new. This optimization speeds up those calls significantly when using MongoDB. Signed-off-by: Derek Trider <Derek.Trider@securekey.com>
DRK3
force-pushed
the
MongoDBBatchOptimization
branch
from
13ab8ec
to
ba6038d
Compare
fqutishat
approved these changes
Dec 7, 2021
bstasyszyn
approved these changes
Dec 7, 2021
| @@ -70,6 +70,8 @@ func (s *Store) Put(anchorID string, witnesses []*proof.Witness) error { | |||
|
|
|||
| anchorIDEncoded := base64.RawURLEncoding.EncodeToString([]byte(anchorID)) | |||
|
|
|||
| putOptions := &storage.PutOptions{IsNewKey: true} | |||
There was a problem hiding this comment.
Actually, it's fine. I didn't notice that a UUID was used as the key.
sandrask
approved these changes
Dec 7, 2021
vkubiv
pushed a commit
to vkubiv/orb
that referenced
this pull request
Dec 7, 2021
feat: MongoDB batch call speed optimization Signed-off-by: Volodymyr Kubiv <volodymyr.kubiv@euristiq.com>
vkubiv
pushed a commit
to vkubiv/orb
that referenced
this pull request
Dec 7, 2021
feat: MongoDB batch call speed optimization Signed-off-by: Volodymyr Kubiv <volodymyr.kubiv@euristiq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an optimization for places that call the store.Batch method using keys that are guaranteed to be new. This optimization speeds up those calls significantly when using MongoDB.
Signed-off-by: Derek Trider Derek.Trider@securekey.com