Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Reuse existing storage provider for ActivityPub #924

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

bstasyszyn
Copy link
Contributor

Reusing the existing storage provider for the ActivityPub storage reduces the number of connections to MongoDB.

closes #916

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

@cla-bot cla-bot bot added the cla-signed label Dec 6, 2021
Reusing the existing storage provider for the ActivityPub storage reduces the number of connections to MongoDB.

closes trustbloc#916

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #924 (51a90bd) into main (882dff4) will increase coverage by 0.06%.
The diff coverage is 61.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #924      +/-   ##
==========================================
+ Coverage   89.28%   89.35%   +0.06%     
==========================================
  Files         159      159              
  Lines       14553    14541      -12     
==========================================
- Hits        12994    12993       -1     
+ Misses        957      947      -10     
+ Partials      602      601       -1     
Impacted Files Coverage Δ
cmd/orb-server/startcmd/start.go 72.80% <61.11%> (-0.04%) ⬇️
...pub/service/inbox/httpsubscriber/httpsubscriber.go 100.00% <0.00%> (+9.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 882dff4...51a90bd. Read the comment docs.

@bstasyszyn bstasyszyn merged commit d06b4e6 into trustbloc:main Dec 6, 2021
@bstasyszyn bstasyszyn deleted the 916 branch December 6, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ActivityPub store should reuse the DB provider that's used by other databases
3 participants