Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check issuer during proof check. #32

Merged

Conversation

vkubiv
Copy link
Contributor

@vkubiv vkubiv commented Oct 25, 2023

No description provided.

@cla-bot cla-bot bot added the cla-signed label Oct 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (04cf7f1) 87.75% compared to head (f721671) 87.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   87.75%   87.67%   -0.08%     
==========================================
  Files          53       53              
  Lines        7938     7946       +8     
==========================================
+ Hits         6966     6967       +1     
- Misses        708      714       +6     
- Partials      264      265       +1     
Files Coverage Δ
jwt/jose_wrappers.go 81.25% <100.00%> (ø)
proof/checker/checker.go 86.85% <100.00%> (-0.08%) ⬇️
verifiable/bbs_selective_disclosure.go 71.06% <100.00%> (ø)
verifiable/credential.go 89.23% <100.00%> (+0.59%) ⬆️
verifiable/credential_jws.go 100.00% <ø> (ø)
verifiable/credential_jwt.go 92.37% <100.00%> (+0.13%) ⬆️
verifiable/credential_jwt_unsecured.go 100.00% <100.00%> (ø)
verifiable/credential_sdjwt.go 91.31% <100.00%> (+0.09%) ⬆️
verifiable/embedded_proof.go 95.08% <100.00%> (+0.08%) ⬆️
verifiable/jws.go 63.33% <100.00%> (-4.24%) ⬇️
... and 8 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vkubiv vkubiv force-pushed the fix-check-issuer-during-proof-check branch 2 times, most recently from bb6cab5 to f721671 Compare October 25, 2023 10:17
Signed-off-by: Volodymyr Kubiv <volodymyr.kubiv@euristiq.com>
@vkubiv vkubiv force-pushed the fix-check-issuer-during-proof-check branch from f721671 to 5902108 Compare October 25, 2023 10:39
@fqutishat fqutishat merged commit 29b6be3 into trustbloc:main Oct 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants