Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: jwt parse with issuer check #33

Merged

Conversation

vkubiv
Copy link
Contributor

@vkubiv vkubiv commented Oct 26, 2023

No description provided.

@cla-bot cla-bot bot added the cla-signed label Oct 26, 2023
@vkubiv vkubiv force-pushed the refactor-jwt-parse-with-issuer-check branch from 2e23060 to 77a0f90 Compare October 26, 2023 06:57
@vkubiv vkubiv changed the title Refactor jwt parse with issuer check refactor: jwt parse with issuer check Oct 26, 2023
@vkubiv vkubiv force-pushed the refactor-jwt-parse-with-issuer-check branch from 77a0f90 to eb60496 Compare October 26, 2023 07:02
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (29b6be3) 87.72% compared to head (fcf9986) 87.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   87.72%   87.79%   +0.07%     
==========================================
  Files          53       53              
  Lines        7942     7967      +25     
==========================================
+ Hits         6967     6995      +28     
+ Misses        710      708       -2     
+ Partials      265      264       -1     
Files Coverage Δ
jwt/jose_wrappers.go 88.88% <100.00%> (+7.63%) ⬆️
jwt/jwt.go 93.44% <100.00%> (-0.61%) ⬇️
sdjwt/holder/holder.go 97.91% <100.00%> (+1.94%) ⬆️
sdjwt/verifier/verifier.go 95.56% <100.00%> (+1.22%) ⬆️
verifiable/embedded_proof.go 95.08% <100.00%> (ø)
verifiable/linked_data_proof.go 93.47% <100.00%> (ø)
verifiable/presentation_jws.go 100.00% <100.00%> (+13.04%) ⬆️
verifiable/presentation.go 88.58% <50.00%> (ø)
verifiable/credential.go 89.00% <57.14%> (-0.23%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Volodymyr Kubiv <volodymyr.kubiv@euristiq.com>
@vkubiv vkubiv force-pushed the refactor-jwt-parse-with-issuer-check branch from eb60496 to fcf9986 Compare October 26, 2023 07:08
@fqutishat fqutishat merged commit 81b5436 into trustbloc:main Oct 26, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants