Skip to content
This repository has been archived by the owner on Aug 25, 2023. It is now read-only.

refactor: Add env variable to define supported auth mode #333

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

ypukhta
Copy link
Contributor

@ypukhta ypukhta commented Sep 13, 2022

Addresses issue #330

TODO:

  • Add tests to cover the following cases:
    • ZCAP auth only
    • GNAP auth only
    • No auth specified
  • Restructure kms-server auth mode code to simplify future maintenance

Signed-off-by: Yevgen Pukhta eugene.pukhta@gmail.com

@cla-bot cla-bot bot added the cla-signed label Sep 13, 2022
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #333 (8285cd2) into main (03f2fb0) will increase coverage by 0.10%.
The diff coverage is 93.54%.

@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
+ Coverage   87.00%   87.11%   +0.10%     
==========================================
  Files          26       26              
  Lines        2132     2150      +18     
==========================================
+ Hits         1855     1873      +18     
  Misses        176      176              
  Partials      101      101              
Impacted Files Coverage Δ
cmd/kms-server/startcmd/params.go 92.26% <90.90%> (+0.80%) ⬆️
cmd/kms-server/startcmd/start.go 76.23% <100.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ypukhta ypukhta force-pushed the issue-330 branch 2 times, most recently from b34c580 to 84c82c6 Compare September 13, 2022 20:00
@ypukhta ypukhta self-assigned this Sep 13, 2022
@ypukhta ypukhta marked this pull request as ready for review September 13, 2022 20:14
test/bdd/features/kms_cli.feature Outdated Show resolved Hide resolved
Signed-off-by: Yevgen Pukhta <eugene.pukhta@gmail.com>
@rolsonquadras rolsonquadras merged commit 569b5e2 into trustbloc:main Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants