Fix formatting and clippy errors #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcrossley3
force-pushed
the
formatting
branch
2 times, most recently
from
c6b54d3
to
4e86fb8
Compare
Signed-off-by: Jim Crossley <jim@crossleys.org>
Add nettle dep, caching and rename job Signed-off-by: Jim Crossley <jim@crossleys.org>
Also reorganized a few tests beneath a single `tests` module Signed-off-by: Jim Crossley <jim@crossleys.org>
bobmcwhirter
approved these changes
Mar 5, 2024
jcrossley3
commented
Mar 5, 2024
Comment on lines
-930
to
-931
| #[cfg(test)] | ||
| mod tests { |
There was a problem hiding this comment.
@bobmcwhirter This looks like more changes than it is. I just moved all the tests beneath a single tests module.
jcrossley3
commented
Mar 5, 2024
Comment on lines
+138
to
+142
| // impl From<&&str> for Purl { | ||
| // fn from(value: &&str) -> Self { | ||
| // PackageUrl::from_str(value).unwrap().into() | ||
| // } | ||
| // } |
There was a problem hiding this comment.
@bobmcwhirter I thought this looked weird. It's not used, but I forgot to delete it.
jcrossley3
commented
Mar 5, 2024
| @@ -128,15 +128,18 @@ impl Debug for Purl { | |||
|
|
|||
| impl From<&str> for Purl { | |||
| fn from(value: &str) -> Self { | |||
| PackageUrl::from_str(value).unwrap().into() | |||
There was a problem hiding this comment.
@bobmcwhirter We're using a clippy rule that doesn't like unwrap. We only allow them for tests. I don't know if deriving Default is The Right Thing in this case or not, but seemed harmless.
There was a problem hiding this comment.
I think the answer is TryFrom instead since failure is an option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More work toward #1