Make system property and file operations injectable #47
Conversation
| @@ -245,33 +257,33 @@ private static String normalize(String value) { | |||
| return value.toLowerCase(Locale.US).replaceAll("[^a-z0-9]+", ""); | |||
| } | |||
|
|
|||
| private static LinuxRelease getLinuxRelease() { | |||
| private static LinuxRelease getLinuxRelease(FileActionFacade fileActionFacade) { | |||
There was a problem hiding this comment.
Since this and similar are private, it may make sense to make them non-static instead of passing in the providers.
There was a problem hiding this comment.
Yeah. I was unsure about determineBitness() as it was public (I turned it to private and thought it would be easy to flip it back if they were intended to be public APIs).
Anyway, now I changed those static utilities to no non-static helpers. @trustin Please let me know if the change to determineBitness() is broken.
We would need this for making changes to our Gradle plugins. But it isn't something super critical, so you can keep with your release schedule. |
|
@trustin Hmm... If possible, could you make a release including this recently? 😃 |
|
@voidzcy Just released 1.7.0. 🎉 |
Creates interfaces for abstracting away system property and file
operations. Wrapper plugins can inject their own code for
performing those operations in ways compliant to the
environment/tool.
See details in #48.
/cc @ejona86