-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Liquidator + PriceFeed + ReservePool #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit concerned about the IOUs. Due to the Time Value of Money, the value of the redeemed IOUs will be less than the amount owed. The receiver could have otherwise invested the money he uses to purchase the IOUs, thus earning a return higher than what the IOUs can offer. Will people be incentivized to buy and hold IOUs?
edit: I'm reading that the IOUs have a step function and there's a max price. was there any reason why 50% was chosen as the max, instead of 100% (or greater)?
also, follow up question: do you expect that the peg would break if the system were to issue IOUs that are redeemable for less than $1 per AUR?
collTypes[collId].ftso = ftso; | ||
} | ||
|
||
function updateMinCollRatio(bytes32 collId, uint256 newMinCollRatio) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs visibility keyword
contracts/probity/PriceFeed.sol
Outdated
collTypes[collId].minCollRatio = minCollRatio; | ||
} | ||
|
||
function updateFtso(bytes32 collId, ftsoLike newFtso) onlyBy("gov") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs visibility keyword
We are allowing user to redeem their IOU at any time (assuming the system have reserve to be redeemed), if the system is working properly and keep accumulating reserve, user will be able to redeem their IOU within a short period of time. Since iousPerAur start at 1 and it incrementally increases as time passes, user will be able to get "interest" on the risk they are taking. We can change this value to increase incentive.
I just chose an arbitrary number for now, they should be changeable via governance
No, because as long as |
#51 replaces this PR, closing |
No description provided.