This repository has been archived by the owner on May 28, 2019. It is now read-only.
Add blockchain assignment to wanchain on Coin init #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,6 +27,8 @@ public struct Coin: Equatable { | |||
| blockchain = .ropsten | |||
| case Coin.ethereumClassic.coinType: | |||
| blockchain = .ethereumClassic | |||
| case Coin.wanchain.coinType: | |||
| blockchain = .wanchain | |||
There was a problem hiding this comment.
Shouldn't blockchain be Ethereum?
There was a problem hiding this comment.
Wanchain has extended transaction format, it includes transaction type. So when we sign we need to distinguish this.
This is types: https://github.com/wanchain/go-wanchain/blob/8bbb49061b4bb371ce034b72e52542beb7d67b95/core/types/transaction.go#L524
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
+ Coverage 84.7% 84.72% +0.02%
==========================================
Files 47 47
Lines 1804 1807 +3
==========================================
+ Hits 1528 1531 +3
Misses 276 276
Continue to review full report at Codecov.
|
alejandro-isaza
approved these changes
Aug 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.