Skip to content
This repository has been archived by the owner on May 28, 2019. It is now read-only.

[WIP] Add VeChain signing #36

Merged
merged 2 commits into from
Aug 28, 2018
Merged

[WIP] Add VeChain signing #36

merged 2 commits into from
Aug 28, 2018

Conversation

vikmeup
Copy link
Contributor

@vikmeup vikmeup commented Aug 27, 2018

No description provided.

@trust-bot
Copy link

trust-bot commented Aug 27, 2018

1 Warning
⚠️ PR is classed as Work in Progress

SwiftLint found issues

Warnings

File Line Reason
VechainTransactionTests.swift 32 Unused parameter "hash" in a closure should be replaced with _.
VechainTransactionTests.swift 23 Multi-line collection literals should have trailing commas.

Generated by 🚫 Danger

// dependsOn: string, ID of the transaction on which the current transaction depends
// nonce :uint64 transaction nonce customizable by user .
// reserved : array Must be empty array.
// Signature : signature of the hash of the transaction body 𝛺, that is, 𝑠𝑖𝑔𝑛𝑎𝑡𝑢𝑟𝑒 = 𝑠𝑖𝑔𝑛(ℎ𝑎𝑠ℎ(𝛺), 𝑝𝑟𝑖𝑣𝑎𝑡𝑒_𝑘𝑒𝑦).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this stuff.

@codecov-io
Copy link

Codecov Report

Merging #36 into master will increase coverage by 0.54%.
The diff coverage is 96.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   83.11%   83.66%   +0.54%     
==========================================
  Files          53       56       +3     
  Lines        1949     2026      +77     
==========================================
+ Hits         1620     1695      +75     
- Misses        329      331       +2
Impacted Files Coverage Δ
Tests/VeChain/VechainTransactionTests.swift 100% <100%> (ø)
Sources/VeChain/VechainClause.swift 100% <100%> (ø)
Sources/VeChain/VechainTransaction.swift 100% <100%> (ø)
Sources/Ethereum/RLP.swift 60.19% <91.42%> (+7.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dde56c...d5eb30e. Read the comment docs.

@vikmeup vikmeup merged commit ea13c1a into master Aug 28, 2018
@vikmeup vikmeup deleted the vechain-blockchain branch August 28, 2018 07:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants