This repository has been archived by the owner on May 28, 2019. It is now read-only.
Add recoverPubkey method #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
+ Coverage 82.18% 82.32% +0.13%
==========================================
Files 68 68
Lines 2835 2863 +28
==========================================
+ Hits 2330 2357 +27
- Misses 505 506 +1
Continue to review full report at Codecov.
|
alejandro-isaza
approved these changes
Sep 5, 2018
Sources/Crypto.h
Outdated
| @@ -38,6 +38,13 @@ | |||
| /// @return whether the signature is valid | |||
| + (BOOL)verifySignature:(nonnull NSData *)signature message:(nonnull NSData *)message publicKey:(nonnull NSData *)publicKey NS_SWIFT_NAME(verify(signature:message:publicKey:)); | |||
|
|
|||
| /// Try computing public key from signature and hashed message | |||
There was a problem hiding this comment.
Recovers the public key from a signature and a message hash.
Sources/Crypto.h
Outdated
| /// | ||
| /// @param signature signature of a signed message | ||
| /// @param message hashed message | ||
| /// @return public key data |
There was a problem hiding this comment.
@return public key or nil if the signature is not valid.
vikmeup
approved these changes
Sep 5, 2018
|
Don't merge this right now, I'm testing with web3 provider |
vikmeup
approved these changes
Sep 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix #43