This repository has been archived by the owner on May 28, 2019. It is now read-only.
Tron transaction signing #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwiftLint found issuesWarnings
Errors
Generated by 🚫 Danger |
| @@ -0,0 +1,4377 @@ | |||
| // DO NOT EDIT. | |||
There was a problem hiding this comment.
Can we include the original protobuf file and a script to generate this instead?
There was a problem hiding this comment.
I've updated README.md to include the steps
Sources/Data+String.swift
Outdated
| import Foundation | ||
|
|
||
| extension Data { | ||
| public func toString() -> String { |
There was a problem hiding this comment.
I don't think these extensions are useful. They don't provide any extra clarity on use and introduce an unexpected side effect of returning empty string on error.
There was a problem hiding this comment.
Yes they are redundant, will remove them, cheers.
Sources/Data+String.swift
Outdated
| } | ||
| } | ||
|
|
||
| extension String { |
| } | ||
|
|
||
| public mutating func addSignature(_ signature: Data) { | ||
| self.signature.append(signature) |
There was a problem hiding this comment.
self is redundant here.
Sources/Tron/TronTransaction.swift
Outdated
| } | ||
|
|
||
| extension TronTransaction.RawData { | ||
| public mutating func toData() -> Data { |
There was a problem hiding this comment.
I don't think this should be mutating, we should return a copy of the data.
There was a problem hiding this comment.
That makes sense, will fix it.
|
Please exclude |
…otocol Buffer to Swift
# Conflicts: # TrustCore.xcodeproj/project.pbxproj
alejandro-isaza
approved these changes
Sep 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test case is in TronTransactionTests