Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix personal_sign compatibility issues #346

Merged
merged 1 commit into from Nov 25, 2022
Merged

Fix personal_sign compatibility issues #346

merged 1 commit into from Nov 25, 2022

Conversation

sherardxu
Copy link
Contributor

Compatible with various personal_sign calling methods.

MetaMask Test Dapp

{
    "id": 1669276639299,
    "method": "personal_sign",
    "params":
    [
        "0x4578616d706c652060706572736f6e616c5f7369676e60206d657373616765",
        "0x0000000000000000000000000000000000000000",
        "Example password"
    ]
}

MOBOX

{
    "id": 1669276574176,
    "method": "personal_sign",
    "params":
    [
        "0x0000000000000000000000000000000000000000",
        "wallet_login_27821276"
    ]
}

(cherry picked from commit e76436d)
@hewigovens hewigovens merged commit e3f1b0a into trustwallet:master Nov 25, 2022
Copy link

@Alkhatri77 Alkhatri77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{
"id": 1669276574176,
"method": "personal_sign",
"params":
[
"0x0000000000000000000000000000000000000000",
"wallet_login_27821276"
]
}

Copy link

@Alkhatri77 Alkhatri77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/ethereum_provider.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants