Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Zilliqa #7

Closed
13 tasks done
hewigovens opened this issue Feb 17, 2019 · 14 comments · Fixed by #419
Closed
13 tasks done

Add support for Zilliqa #7

hewigovens opened this issue Feb 17, 2019 · 14 comments · Fixed by #419
Assignees

Comments

@hewigovens
Copy link
Contributor

hewigovens commented Feb 17, 2019

Name: Zilliqa
HD Derivation Scheme: BIP44 / 313
Symbol: ZIL

Checklist

  • Implement functionality in C++. Put it in a subfolder of src/.
    • Address (if necessary)
    • Transaction (if necessary)
    • Signer
  • Write unit tests. Put them in a subfolder of tests/.
  • Add relevant constants in TWCoinType, TWP2SHPrefix, TWEthereymChainID, TWHRP, etc., as necessary.
  • Return correct curve and purpose in src/Coin.cpp.
  • Implement address validation and derivation in src/Coin.cpp.
  • Implement coin configuration src/include/TWCoinTypeConfiguration.cpp.
  • Write interface header in include/TrustWalletCore and implement the interface in src/interface.
    • Address interface (if necessary).
    • Signing interface.
  • Validate generated code in Android an iOS projects. Write integration tests for each.
This was referenced Feb 21, 2019
@hewigovens hewigovens self-assigned this Feb 24, 2019
@snowsledge
Copy link

@kurotych
Copy link
Contributor

In progress

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 200000.0 ZIL attached to it as part of the Zilliqa fund.

@gitcoinbot
Copy link

@armatusmiles Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@kurotych
Copy link
Contributor

@armatusmiles Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Yes i'm still working

@gitcoinbot
Copy link

@armatusmiles Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@kurotych
Copy link
Contributor

@armatusmiles Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

yes

@gitcoinbot
Copy link

@armatusmiles Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@armatusmiles Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@armatusmiles due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@armatusmiles due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

gitcoinbot commented May 7, 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 3 months, 4 weeks from now.
Please review their action plans below:

1) eladelrom has applied to start work (Funders only: approve worker | reject worker).

Hi, I will be happy to help implement this feature and add support for Zilliqa for trust wallet. I will be following the checklist you outlined, here: #7.

Thanks, Elad Elrom.
2) hewigovens has been approved to start work.

it's done in #419

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@hewigovens due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 200000.0 ZIL (4124.0 USD @ $0.02/ZIL) attached to this issue has been approved & issued to @hewigovens.

EnoRage referenced this issue in EnoRage/wallet-core Dec 2, 2019
vikmeup pushed a commit that referenced this issue Dec 3, 2019
* [Any::Stellar] - In progress rn

* Placed valid json for stellar transaction test

* fix & un-comment stellar signer sign call

* [Any::Stellar] - In progress rn, add some fixes

* [Any::Stellar] - In progress rn, add some fixes

* [Any::Stellar] - Added successfully.

* [Any::Stellar] - Added successfully. Cleanup

* [Any::Stellar] - Added successfully. Cleanup #2

* [Any::Stellar] - Added successfully. Cleanup #3

* [Any::Stellar] - Added successfully. Cleanup #4

* [Any::Stellar] - Added successfully. Cleanup #5

* [Any::Stellar] - Added successfully. Cleanup #6

* [Any::Stellar] - Added successfully. Cleanup #7

* [Any::Stellar] - Added successfully. Cleanup #8

* [Any::Stellar] - Added successfully. Cleanup #9
EnoRage referenced this issue in EnoRage/wallet-core Jan 1, 2020
* [Any::Stellar] - In progress rn

* Placed valid json for stellar transaction test

* fix & un-comment stellar signer sign call

* [Any::Stellar] - In progress rn, add some fixes

* [Any::Stellar] - In progress rn, add some fixes

* [Any::Stellar] - Added successfully.

* [Any::Stellar] - Added successfully. Cleanup

* [Any::Stellar] - Added successfully. Cleanup #2

* [Any::Stellar] - Added successfully. Cleanup #3

* [Any::Stellar] - Added successfully. Cleanup #4

* [Any::Stellar] - Added successfully. Cleanup #5

* [Any::Stellar] - Added successfully. Cleanup #6

* [Any::Stellar] - Added successfully. Cleanup #7

* [Any::Stellar] - Added successfully. Cleanup trustwallet#8

* [Any::Stellar] - Added successfully. Cleanup trustwallet#9
@han0147 han0147 mentioned this issue Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants