Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for idempotencyKey for POST methods #16

Merged
merged 3 commits into from
Aug 10, 2020
Merged

Added support for idempotencyKey for POST methods #16

merged 3 commits into from
Aug 10, 2020

Conversation

aydrian
Copy link
Contributor

@aydrian aydrian commented Aug 6, 2020

Description of the change

  • Added optional config object for POST requests. Users can now set an idempotencyKey on POST request methods which will be written to the Idempotency-Key header.
  • Added tests
  • Updated README.md to include Idempotency section
  • Updated unreleased section of Changelog

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@aydrian aydrian requested a review from a team August 6, 2020 12:54
@aydrian aydrian self-assigned this Aug 6, 2020
@aydrian aydrian marked this pull request as ready for review August 6, 2020 12:56
@aydrian aydrian merged commit ff915e6 into master Aug 10, 2020
@aydrian aydrian deleted the aydrian/idempotency branch August 10, 2020 19:05
@nebbles nebbles mentioned this pull request Sep 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileylnapier rileylnapier rileylnapier approved these changes

@tone81 tone81 tone81 approved these changes

Assignees

@aydrian aydrian

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aydrian @tone81 @rileylnapier