Fix a bug when parsing a list with line breaks #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello👋
I am using tryfabric/mack on Slack and I found a bug that I would like to fix with this PR.
Issue
I have found that the code is not converting lists with line breaks correctly. For example:
The output of the conversion looks like this:
Solution
I have fixed this issue by modifying the
parseList()
function. The issue was caused by the function returning an empty string whentokens[0]
was empty, but the actual content could be intokens[1]
.The
tokens
array could look like this, with onespace
and onetext
: