Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.1.0 #25

Merged
merged 4 commits into from
Jul 25, 2019
Merged

2.1.0 #25

merged 4 commits into from
Jul 25, 2019

Conversation

atomicpages
Copy link
Contributor

@atomicpages atomicpages commented Jul 19, 2019 •
edited
Loading

  • Adding CLI interface
  • Updating README with example using hooks in React
  • Bumping dependencies to address security issues
  • Adding .editorconfig so IDEs and other text editors that support editor config picks up preferred formatting automatically
  • Closes Provide a CLI Interface #24

@atomicpages
2.1.0
c35f958 
* Adding CLI interface
@atomicpages
2.1.0
a94fe6a 
* Adding strategy option in CLI interface with default
* Adding docs for CLI interface
tryggvigy
tryggvigy reviewed Jul 21, 2019
View reviewed changes
README.md Show resolved Hide resolved
@atomicpages
2.1.0
11cb72d 
* Adding support for direct input via pipe or option
* Setting some rules to -i and src don't conflict
tryggvigy
tryggvigy reviewed Jul 24, 2019
View reviewed changes
Copy link
Owner

@tryggvigy tryggvigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! just a few comments

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
bin/pseudo-localize Outdated Show resolved Hide resolved
bin/pseudo-localize Show resolved Hide resolved
@tryggvigy
Copy link
Owner

Sorry to conflict with you. I merged #26 to get eslint in :)

@tryggvigy
Copy link
Owner

@atomicpages this is LGTM! I'll take a final look after work today. Let's get this in 🎉

@tryggvigy tryggvigy merged commit dbf2f3c into tryggvigy:master Jul 25, 2019
@tryggvigy
Copy link
Owner

Merged! I'll make a release on npm now. Should be out soon

@atomicpages
Copy link
Contributor Author

Sweet! Thanks for merging!

@tryggvigy
Copy link
Owner

2.1.0 is out: https://www.npmjs.com/package/pseudo-localization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tryggvigy tryggvigy tryggvigy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide a CLI Interface
2 participants
@atomicpages @tryggvigy