Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selected date pulls up to overlap with Date-Time Range when snackbar alert triggered #633

Closed
Brian-Lee opened this issue Apr 16, 2020 · 0 comments · Fixed by #634
Closed

Selected date pulls up to overlap with Date-Time Range when snackbar alert triggered #633

Brian-Lee opened this issue Apr 16, 2020 · 0 comments · Fixed by #634

Comments

@Brian-Lee
Copy link
Contributor

When a snackbar alert "Please select at least one day of week overlapping with the date range." is triggered (and the "Apply" button is simultaneously disabled due to the triggering of the condition in PR #628, the date selector moves up a bit to overlap with the text "Date-Time Range"

This bug was introduced in PR #628

overlap
Brian-Lee added a commit that referenced this issue Apr 16, 2020
@Brian-Lee
fixes #633
3e25f9a
@Brian-Lee Brian-Lee mentioned this issue Apr 16, 2020
Merged
Brian-Lee added a commit that referenced this issue Apr 21, 2020
@Brian-Lee
fixes #633 and code style improvements (#634)
309af9d 
* code style improvement - define Moment objects once instead of three times each

* eliminated unecessary conversion from Moment object to date

* fixes #633
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes #633 and code style improvements trynmaps/metrics-mvp
1 participant
@Brian-Lee