Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add did to Vehicle type #21

Merged
merged 1 commit into from
May 24, 2018
Merged

Add did to Vehicle type #21

merged 1 commit into from
May 24, 2018

Conversation

vonrosen
Copy link

@vonrosen vonrosen commented May 21, 2018 •
edited by EddyIonescu
Loading

#20

@EddyIonescu EddyIonescu self-requested a review May 24, 2018 01:17
EddyIonescu
EddyIonescu approved these changes May 24, 2018
View reviewed changes
Copy link
Member

@EddyIonescu EddyIonescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - could you just add the issue link into the commit message once you sqaush&merge? #20

@EddyIonescu
Copy link
Member

#20

@vonrosen vonrosen merged commit 30cbc55 into master May 24, 2018
@vonrosen vonrosen mentioned this pull request May 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EddyIonescu EddyIonescu EddyIonescu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vonrosen @EddyIonescu