Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add icon to Photino.Blazor nuget package and sample #36

Merged
merged 8 commits into from
Jan 27, 2022
Merged

Add icon to Photino.Blazor nuget package and sample #36

merged 8 commits into from
Jan 27, 2022

Conversation

tomlm
Copy link
Contributor

@tomlm tomlm commented Jan 14, 2022 •
edited
Loading

  • added photino default favicon.ico to nuget package
  • added photino default favicon.ico to process and window

Tom Laird-McConnell added 6 commits January 9, 2022 19:20
@NewMySQL
Copy link
Contributor

NewMySQL commented Jan 15, 2022 •
edited
Loading

Your example (MudBlazor) is not stable, if you often switch between Nav-Links, then "An unhandled error has occurred" appears.

blazor.webview.js:1 

Received unexpected acknowledgement for render batch 46 (next batch should be 45)
at Microsoft.AspNetCore.Components.WebView.Services.WebViewRenderer.NotifyRenderCompleted(Int64 batchId)
at Microsoft.AspNetCore.Components.WebView.IpcReceiver.OnMessageReceivedAsync(PageContext pageContext, String message)
at Microsoft.AspNetCore.Components.WebView.WebViewManager.<>c__DisplayClass18_0.<<MessageReceived>b__0>d.MoveNext()

@NewMySQL NewMySQL mentioned this pull request Jan 17, 2022
Closed
@tomlm
Copy link
Contributor Author

tomlm commented Jan 20, 2022

@NewMySQL , with your sync fix in your PR is MudBlazor sample stable?

@NewMySQL
Copy link
Contributor

@NewMySQL , with your sync fix in your PR is MudBlazor sample stable?

Yes, stable

MikeYeager
MikeYeager requested changes Jan 20, 2022
View reviewed changes
Copy link
Collaborator

@MikeYeager MikeYeager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the sample and template. We believe these should go in the Photino.Samples and PhotinoSamples.VSCodeExtensions and PhotinoSamples.VSExtension repos.

@tomlm tomlm closed this Jan 20, 2022
@tomlm tomlm changed the title Add Photino.Blazor.Templates project Add icon to Photino.Blazor nuget package and sample Jan 20, 2022
@tomlm tomlm reopened this Jan 20, 2022
@tomlm
Copy link
Contributor Author

tomlm commented Jan 20, 2022 •
edited
Loading

OK, this is now just adding the icon, I removed MudBlazor and templates from PR.

BTW: The link to vs code templates is either broken or the project is private.
This url:
https://github.com/tryphotino/PhotinoSamples.VSExtension
image

@tomlm tomlm requested a review from MikeYeager January 20, 2022 19:00
@MikeYeager MikeYeager merged commit afc5809 into tryphotino:debug Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeYeager MikeYeager MikeYeager approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomlm @NewMySQL @MikeYeager