Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes to named pipe events #36

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Conversation

Guzzy711
Copy link
Contributor

Pull Request Template

Description

Please provide the below information so we can validate before merging:

  1. Does the proposed EDR feature align with our definition of telemetry?(definition here)
  2. Could you please provide documentation to support the telemetry you are proposing?(If it is held privately, please reach out to me or @inodee)
  3. If no documentation is available for all the categories you are proposing, could you provide screenshots or sanitized logs?

1: (response)
2: (response)
3: (response)

Type of change

Please delete options that are not relevant.

  • Feature Improvement (non-breaking change which fixes an issue)
  • New feature (adding additional EDR product or proposing new event categories/sub-categories)
  • This change requires a documentation update
  • New tool (suggesting additional tools for improving collection and analysis)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Test Configuration:

  • EDR version:
  • Operating System version:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my corrections or additions are accurate
  • I have checked my code and corrected any misspellings

Don't stress yourself out, just answer the above to the best of your ability and we can discuss in the comments 🙂

@tsale
Copy link
Owner

tsale commented Jun 16, 2023

Thank you for this PR @Guzzy711! Could you please provide some evidence for the proposed changes? Feel free to message me privately if you are not feeling comfortable showing the evidence publicly.

@Guzzy711
Copy link
Contributor Author

I'll PM you on Twitter

Copy link
Owner

@tsale tsale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Guzzy711 provided telemetry evidence related to this PR via a private channel. Thank you for the contribution @Guzzy711!

@tsale tsale merged commit 552905b into tsale:main Jun 16, 2023
tsale added a commit that referenced this pull request Jun 16, 2023
Fixed named pipes telemetry for CrowdStrike (#36)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants