Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master #13

Merged
merged 36 commits into from
Nov 2, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
089f722
8248177: Improve XML support
arun-joseph Jul 27, 2020
b297080
Merge
kevinrushforth Aug 14, 2020
be79e8f
Merge
kevinrushforth Aug 25, 2020
f70ec67
Merge
kevinrushforth Sep 8, 2020
081ac75
Merge
kevinrushforth Sep 17, 2020
77a183e
8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if …
arapte Oct 2, 2020
5b42b64
8252236: TabPane: must keep header of selected tab visible
Oct 3, 2020
15e52d8
8253696: WebEngine refuses to load local "file:///" CSS stylesheets w…
arun-joseph Oct 6, 2020
1c485a3
8252191: Update to gcc 10.2 on Linux
kevinrushforth Oct 6, 2020
7857022
8251946: ObservableList.setAll does not conform to specification
TheMrMilchmann Oct 7, 2020
184f12c
8252192: Update to Visual Studio 2019 version 16.7.2
kevinrushforth Oct 7, 2020
a56ba63
8254255: Remove obsolete .hgignore file
kevinrushforth Oct 8, 2020
58d06e2
Merge
kevinrushforth Oct 9, 2020
205e4b9
8178297: TableView scrolls slightly when adding new elements
Oct 12, 2020
00f5b7c
8253597: TreeTableView: must select leaf row on click into indentatio…
Oct 12, 2020
eaabfc5
8253935: [testbug] ComboBoxTest.testEditorKeyInputsWhenPopupIsShowing…
arapte Oct 14, 2020
eb626aa
8254040: [testbug] Need additional regressions tests for ObservableLi…
Oct 14, 2020
e856a58
8246202: ChoiceBoxSkin: misbehavior on switching skin, part 2
Oct 15, 2020
31fce21
8223375: Remove Netbeans specific files from the source code repository
kevinrushforth Oct 16, 2020
aab26d9
8217472: Add attenuation for PointLight
nlisker Oct 19, 2020
01ba6e1
8254605: repaint on Android broken
Oct 19, 2020
9c73dcc
Merge
kevinrushforth Oct 19, 2020
a369938
8254964: Fix default values in Spinner class
nlisker Oct 20, 2020
ae1fb61
8255002: Many javafx.controls unit tests have incorrect name containi…
aghaisas Oct 22, 2020
16b697c
8254100: FX: Update copyright year in docs, readme files to 2021
arapte Oct 22, 2020
a5a71d1
8247494: Test failure in ImageRaceTest on some systems
Oct 22, 2020
4e5f0e6
8252596: [TESTBUG] WebPageShim::paint is not thread-safe
arun-joseph Oct 22, 2020
243b1a5
8255241: [TestBug] Re-enable few ignored tests in javafx.controls mod…
aghaisas Oct 23, 2020
2c67555
8213573: MouseLocationOnScreenTest fails intermittently
Oct 23, 2020
690d266
8255337: [TestBug] Controls unit tests - ButtonTest and ComboBoxTest …
aghaisas Oct 28, 2020
4f1eb7d
8254013: gradle test should run all test classes even if they don't e…
kevinrushforth Oct 28, 2020
7da928b
8255497: [TestBug] Controls unit tests - clean up unnecessary prints …
aghaisas Oct 28, 2020
0376e60
8255487: Mark SandboxAppTest unstable on Windows
kevinrushforth Oct 29, 2020
1a11334
8244297: Provide utility for testing for memory leaks
FlorianKirmaier Oct 30, 2020
51c09e5
8254691: Enable GitHub actions for jfx repo
kevinrushforth Oct 31, 2020
cb545cc
8253634: TreeCell/Skin: misbehavior on switching skin
Nov 1, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
285 changes: 285 additions & 0 deletions .github/workflows/submit.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,285 @@
#
# Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved.
# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
#
# This code is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License version 2 only, as
# published by the Free Software Foundation. Oracle designates this
# particular file as subject to the "Classpath" exception as provided
# by Oracle in the LICENSE file that accompanied this code.
#
# This code is distributed in the hope that it will be useful, but WITHOUT
# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
# version 2 for more details (a copy is included in the LICENSE file that
# accompanied this code).
#
# You should have received a copy of the GNU General Public License version
# 2 along with this work; if not, write to the Free Software Foundation,
# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
#
# Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
# or visit www.oracle.com if you need additional information or have any
# questions.
#

#
# This GitHub actions YAML file runs a build and test on each of the three primary platforms:
# Linux, macOS, Windows. The jobs are run using the default (latest) OS platform for each OS.
# We download a specific version the boot JDK and gradle. We use the default versions
# of all other build tools (e.g., compilers and ant) that are available on each platform.
#
# The build step is run in the default mode without building the native media or webkit libraries.
# The test is run with web tests excluded. As a follow-up enhancement, we might consider optionally
# building the media and webkit libraries.
#

name: JavaFX pre-submit tests

on:
# Run GitHub actions on every push to all branches except the main production branches, also
# exclude any branch starting with "WIP".
push:
branches-ignore:
- master
- main
- 'jfx[0-9]+'
- 'WIP*'

jobs:
linux_x64_build:
name: Linux x64
runs-on: "ubuntu-latest"
if: 'true'

env:
# FIXME: read this information from a property file
# BOOT_JDK_VERSION: "${{ fromJson(needs.prerequisites.outputs.dependencies).BOOT_JDK_VERSION }}"
# BOOT_JDK_FILENAME: "${{ fromJson(needs.prerequisites.outputs.dependencies).LINUX_X64_BOOT_JDK_FILENAME }}"
# BOOT_JDK_URL: "${{ fromJson(needs.prerequisites.outputs.dependencies).LINUX_X64_BOOT_JDK_URL }}"
# BOOT_JDK_SHA256: "${{ fromJson(needs.prerequisites.outputs.dependencies).LINUX_X64_BOOT_JDK_SHA256 }}"
BOOT_JDK_VERSION: "15"
BOOT_JDK_FILENAME: "openjdk-15_linux-x64_bin.tar.gz"
BOOT_JDK_URL: "https://download.java.net/java/GA/jdk15/779bf45e88a44cbd9ea6621d33e33db1/36/GPL/openjdk-15_linux-x64_bin.tar.gz"

steps:
- name: Checkout the source
uses: actions/checkout@v2
with:
path: jfx

- name: Install dependencies
run: |
set -x
sudo apt-get install libgl1-mesa-dev libx11-dev libxt-dev pkg-config libgtk2.0-dev libgtk-3-dev libxtst-dev libudev-dev

# FIXME: enable cache for boot JDK
# - name: Restore boot JDK from cache
# id: bootjdk
# uses: actions/cache@v2
# with:
# path: ~/bootjdk/${{ env.BOOT_JDK_VERSION }}
# key: bootjdk-${{ runner.os }}-${{ env.BOOT_JDK_VERSION }}-${{ env.BOOT_JDK_SHA256 }}-v1

- name: Download boot JDK
run: |
set -x
mkdir -p "${HOME}/bootjdk"
wget -O "${HOME}/bootjdk/${BOOT_JDK_FILENAME}" "${BOOT_JDK_URL}"
# FIXME: sha256sum
tar -xf "${HOME}/bootjdk/${BOOT_JDK_FILENAME}" -C "${HOME}/bootjdk"
# FIXME: enable cache for boot JDK

- name: Setup environment
run: |
set -x
export JAVA_HOME="${HOME}/bootjdk/jdk-${BOOT_JDK_VERSION}"
echo "JAVA_HOME=${JAVA_HOME}" >> "${GITHUB_ENV}"
export PATH="$JAVA_HOME/bin:$PATH"
env | sort
which java
java -version
ant -version
gcc -v

- name: Build JavaFX artifacts
working-directory: jfx
run: |
set -x
export PATH="$JAVA_HOME/bin:$PATH"
bash gradlew -version
bash gradlew --info all

- name: Run JavaFX headless tests
working-directory: jfx
run: |
set -x
export PATH="$JAVA_HOME/bin:$PATH"
bash gradlew --info --continue -PBUILD_SDK_FOR_TEST=false test -x :web:test


macos_x64_build:
name: macOS x64
runs-on: "macos-latest"
if: 'true'

env:
# FIXME: read this information from a property file
# BOOT_JDK_VERSION: "${{ fromJson(needs.prerequisites.outputs.dependencies).BOOT_JDK_VERSION }}"
# BOOT_JDK_FILENAME: "${{ fromJson(needs.prerequisites.outputs.dependencies).LINUX_X64_BOOT_JDK_FILENAME }}"
# BOOT_JDK_URL: "${{ fromJson(needs.prerequisites.outputs.dependencies).LINUX_X64_BOOT_JDK_URL }}"
# BOOT_JDK_SHA256: "${{ fromJson(needs.prerequisites.outputs.dependencies).LINUX_X64_BOOT_JDK_SHA256 }}"
BOOT_JDK_VERSION: "15"
BOOT_JDK_FILENAME: "openjdk-15_osx-x64_bin.tar.gz"
BOOT_JDK_URL: "https://download.java.net/java/GA/jdk15/779bf45e88a44cbd9ea6621d33e33db1/36/GPL/openjdk-15_osx-x64_bin.tar.gz"

steps:
- name: Checkout the source
uses: actions/checkout@v2
with:
path: jfx

- name: Install dependencies
run: |
set -x
echo "NOT NEEDED: brew install make"

# FIXME: enable cache for boot JDK
# - name: Restore boot JDK from cache
# id: bootjdk
# uses: actions/cache@v2
# with:
# path: ~/bootjdk/${{ env.BOOT_JDK_VERSION }}
# key: bootjdk-${{ runner.os }}-${{ env.BOOT_JDK_VERSION }}-${{ env.BOOT_JDK_SHA256 }}-v1

- name: Download boot JDK
run: |
set -x
mkdir -p "${HOME}/bootjdk"
wget -O "${HOME}/bootjdk/${BOOT_JDK_FILENAME}" "${BOOT_JDK_URL}"
# FIXME: sha256sum
tar -xf "${HOME}/bootjdk/${BOOT_JDK_FILENAME}" -C "${HOME}/bootjdk"
# FIXME: enable cache for boot JDK

- name: Setup environment
run: |
set -x
export JAVA_HOME="${HOME}/bootjdk/jdk-${BOOT_JDK_VERSION}.jdk/Contents/Home"
echo "JAVA_HOME=${JAVA_HOME}" >> "${GITHUB_ENV}"
export PATH="$JAVA_HOME/bin:$PATH"
env | sort
which java
java -version
ant -version
xcodebuild -version

- name: Build JavaFX artifacts
working-directory: jfx
run: |
set -x
export PATH="$JAVA_HOME/bin:$PATH"
bash gradlew -version
bash gradlew --info all

- name: Run JavaFX headless tests
working-directory: jfx
run: |
set -x
export PATH="$JAVA_HOME/bin:$PATH"
bash gradlew --info --continue -PBUILD_SDK_FOR_TEST=false test -x :web:test


windows_x64_build:
name: Windows x64
runs-on: "windows-latest"
if: 'true'

env:
# FIXME: read this information from a property file
# BOOT_JDK_VERSION: "${{ fromJson(needs.prerequisites.outputs.dependencies).BOOT_JDK_VERSION }}"
# BOOT_JDK_FILENAME: "${{ fromJson(needs.prerequisites.outputs.dependencies).LINUX_X64_BOOT_JDK_FILENAME }}"
# BOOT_JDK_URL: "${{ fromJson(needs.prerequisites.outputs.dependencies).LINUX_X64_BOOT_JDK_URL }}"
# BOOT_JDK_SHA256: "${{ fromJson(needs.prerequisites.outputs.dependencies).LINUX_X64_BOOT_JDK_SHA256 }}"
BOOT_JDK_VERSION: "15"
BOOT_JDK_FILENAME: "openjdk-15_windows-x64_bin.zip"
BOOT_JDK_URL: "https://download.java.net/java/GA/jdk15/779bf45e88a44cbd9ea6621d33e33db1/36/GPL/openjdk-15_windows-x64_bin.zip"
# FIXME: hard-code the location and version of VS 2019 for now
VS150COMNTOOLS: "C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\VC\\Auxiliary\\Build"
MSVC_VER: "14.27.29110"

steps:
- name: Checkout the source
uses: actions/checkout@v2
with:
path: jfx

# FIXME: enable cache for boot JDK
# - name: Restore boot JDK from cache
# id: bootjdk
# uses: actions/cache@v2
# with:
# path: ~/bootjdk/${{ env.BOOT_JDK_VERSION }}
# key: bootjdk-${{ runner.os }}-${{ env.BOOT_JDK_VERSION }}-${{ env.BOOT_JDK_SHA256 }}-v1

- name: Download boot JDK
run: |
mkdir -p "$HOME\bootjdk"
& curl -L "$env:BOOT_JDK_URL" -o "$HOME/bootjdk/$env:BOOT_JDK_FILENAME"
# FIXME: sha256sum
tar -xf "$HOME/bootjdk/$env:BOOT_JDK_FILENAME" -C "$HOME/bootjdk"
# FIXME: enable cache for boot JDK

- name: Restore cygwin packages from cache
id: cygwin
uses: actions/cache@v2
with:
path: ~/cygwin/packages
key: cygwin-packages-${{ runner.os }}-v1

- name: Install cygwin
run: |
New-Item -Force -ItemType directory -Path "$HOME\cygwin"
& curl -L "https://www.cygwin.com/setup-x86_64.exe" -o "$HOME/cygwin/setup-x86_64.exe"
Start-Process -FilePath "$HOME\cygwin\setup-x86_64.exe" -ArgumentList "--quiet-mode --packages make,zip,unzip --root $HOME\cygwin\cygwin64 --local-package-dir $HOME\cygwin\packages --site http://mirrors.kernel.org/sourceware/cygwin --no-desktop --no-shortcuts --no-startmenu --no-admin" -Wait -NoNewWindow

- name: Setup environment
run: |
echo "VS150COMNTOOLS=$env:VS150COMNTOOLS"
echo "MSVC_VER=$env:MSVC_VER"
# echo "dir ...\VC\Tools\MSVC"
# dir "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC"
# echo "dir VS150COMNTOOLS"
# dir "$env:VS150COMNTOOLS"

$env:Path = "$HOME\cygwin\cygwin64\bin;$HOME\cygwin\cygwin64\bin;$env:Path" ;
$env:JAVA_HOME = "$HOME\bootjdk\jdk-$env:BOOT_JDK_VERSION" ;
echo "JAVA_HOME=$env:JAVA_HOME"
$env:Path = "$env:JAVA_HOME\bin;$env:Path" ;
echo "Path=$env:Path"
which java
java -version
which ant
ant -version

# Save JAVA_HOME and Path (renamed to THE_PATH) in env variables
echo "JAVA_HOME=$env:JAVA_HOME" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
echo "THE_PATH=$env:Path" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append

- name: Build JavaFX artifacts
working-directory: jfx
run: |
echo "JAVA_HOME=$env:JAVA_HOME"
$env:Path = "$env:THE_PATH" ;
echo "Path=$env:Path"
which java
java -version
.\gradlew.bat -version
.\gradlew.bat --info all

- name: Run JavaFX headless tests
working-directory: jfx
run: |
echo "JAVA_HOME=$env:JAVA_HOME"
$env:Path = "$env:THE_PATH" ;
echo "Path=$env:Path"
.\gradlew.bat --info --continue -PBUILD_SDK_FOR_TEST=false test -x :web:test
73 changes: 0 additions & 73 deletions .hgignore

This file was deleted.

8 changes: 4 additions & 4 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -1936,8 +1936,8 @@ allprojects {
executable = JAVA;
enableAssertions = true;
testLogging.exceptionFormat = "full";
scanForTestClasses = false;
include("**/*Test.*");
scanForTestClasses = true;
include("**/*.*");
if (BUILD_CLOSED && DO_JCOV) {
addJCov(project, test)
}
Expand Down Expand Up @@ -2447,8 +2447,8 @@ project(":graphics") {
"-DCSS_META_DATA_TEST_DIR=$cssDir"
enableAssertions = true
testLogging.exceptionFormat = "full"
scanForTestClasses = false
include "**/*Test.*"
scanForTestClasses = true
include "**/*.*"
if (BUILD_CLOSED && DO_JCOV) {
addJCov(project, test)
}
Expand Down
Loading