Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image croping due to margin #77

Open
bernardoadc opened this issue Nov 5, 2016 · 4 comments
Open

Image croping due to margin #77

bernardoadc opened this issue Nov 5, 2016 · 4 comments
Assignees
Labels

Comments

@bernardoadc
Copy link

Hi, I've found some images were cropped, until I came in to a case that became pretty clear the reason why. Could even reproduce it fairly easy forking your fiddle.
Library version is 2.5.2

Awesome project, by the way!!

@kapyaar
Copy link

kapyaar commented Nov 7, 2016

The issue is with the node margin. A silly Workaround is to put a wrapper to take care of the margin.

https://jsfiddle.net/rfno4beb/1/

:)

@bernardoadc
Copy link
Author

Nice, didn't thought a simple wrapper would solve it, altough several ways could be thought of. Still, would be nice to solve, just to keep the project integrity.

@PixelsCommander
Copy link

PixelsCommander commented Mar 6, 2017

The same thing about border. It crops the thing. Any directions on fixing it? Can make a PR potentially.

julienma added a commit to BaguetteEngineering/dom-to-image that referenced this issue Jul 25, 2017
@ProximaHaiz
Copy link

The issue is with the node margin. A silly Workaround is to put a wrapper to take care of the margin.

https://jsfiddle.net/rfno4beb/1/

:)

Bro, you are the best!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants