Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOM-objects without an style-attribute can now be rendered #184

Closed
wants to merge 1 commit into from
Closed

DOM-objects without an style-attribute can now be rendered #184

wants to merge 1 commit into from

Conversation

Syndesi
Copy link

@Syndesi Syndesi commented Feb 2, 2018

This resolves #182 . Btw, your current tests are sometimes failing, but this new commit doesn't add any new failures :)

@pacproduct
Copy link

@Syndesi : Made a very similar PullRequest that includes a bit more safeguarding. Can't be sure all of them are necessary...

See #246

@Syndesi
Copy link
Author

Syndesi commented Sep 14, 2018

@pacproduct Sry for the late reply, but I moved and had no internet until know. Your pull request is indeed better than my solution and therefore I'll close this one. Maybe @tsayen can merge it in time :)

@Syndesi Syndesi closed this Sep 14, 2018
@tsayen
Copy link
Owner

tsayen commented Sep 19, 2018

Hi, thanks for contributing!
Indeed, you're right about the tests. They fail on my local machine as well, that one with the text node. Well, I can sort it out later.
Your solution looks fine to me, as it doesn't introduce new regression test failures, although it would be nice to add a test for that particular case. Anyway, if you reopen this request, I can merge it.

@ProfessorX737
Copy link

Please merge this change into master. I cannot render image with math without it

@Syndesi Syndesi reopened this Jan 10, 2020
@michaeljelly
Copy link

@tsayen any chance this can be merged now?

michaeljelly added a commit to michaeljelly/dom-to-image that referenced this pull request May 17, 2022
@Syndesi 's commit never was merged into master, and they seem to have deleted their forked repo.

This commit is just re-implementing the change made in tsayen#184 so I can use it.
@Syndesi Syndesi closed this Dec 13, 2023
@Syndesi
Copy link
Author

Syndesi commented Dec 13, 2023

Permanently closed as there is no activity by the repository owner anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Katex (MathML-Library) creates the error "target is undefined"
5 participants