Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an edge case with contains #8

Merged
merged 1 commit into from
Feb 20, 2017
Merged

Conversation

aisaacs
Copy link
Contributor

@aisaacs aisaacs commented Feb 18, 2017

Using contains if the last range is fully contained even though previous ranges aren't, the return value will be ALL.

This is a proposed fix.

@tschaub tschaub merged commit 45206b3 into tschaub:master Feb 20, 2017
@tschaub
Copy link
Owner

tschaub commented Feb 20, 2017

Thanks @aisaacs. I see another couple small changes that can be made in this method (but those shouldn't change the return). I'll add some additional tests when making those changes and cut another release with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants