Skip to content

Commit e1c9971

Browse files
committed
remove loguru as 1st class citizen
1 parent cc2c029 commit e1c9971

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/np/flight/numpy_server.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1+
import logging
12
import threading # Module for creating and managing threads; used for thread safety with locking.
23
from abc import ABC, abstractmethod
34

4-
import loguru # Logging library that simplifies logging setup and usage.
55
import numpy as np
66
import pyarrow.flight as fl # PyArrow's Flight module to handle gRPC-based data transfer with Arrow.
77

@@ -24,7 +24,7 @@ def __init__(self, host="0.0.0.0", port=8080, logger=None, **kwargs):
2424
"""
2525
uri = f"grpc://{host}:{port}"
2626
super().__init__(uri, **kwargs) # Initialize the base FlightServer with the URI.
27-
self._logger = logger or loguru.logger # Use provided logger or default to loguru's logger.
27+
self._logger = logger or logging.getLogger(__name__) # Use provided logger or default to loguru's logger.
2828
self._storage = {} # Dictionary to store uploaded data associated with specific commands.
2929
self._lock = threading.Lock() # Lock for ensuring thread safety when accessing shared resources.
3030

@@ -109,7 +109,6 @@ def start(cls, host="0.0.0.0", port=8080, logger=None, **kwargs): # pragma: no
109109
:param logger: Optional logger to use.
110110
:param kwargs: Additional arguments passed to the constructor.
111111
"""
112-
logger = logger or loguru.logger # If no logger is provided, use loguru's default logger.
113112
server = cls(host=host, port=port, logger=logger, **kwargs) # Instantiate the server.
114113
server.logger.info(f"Starting {cls} Flight server on port {port}...") # Log the server start.
115114
server.serve() # Start the server to handle incoming requests.

0 commit comments

Comments
 (0)