fix: properly fix the empty white space #132
Merged
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
ty sir /tip $20 |
|
🎉🎈 @Ayushjhawar8 has been awarded $20 by tscircuit! 🎈🎊 |
|
Hey Seve, sorry for the inconvenience! The earlier change added unnecessary complexity to the preview containers, which ended up breaking the docs. This PR simplifies the structure by handling background color at the parent level and keeping scaling consistent. I’ve tested across pcb, schematic, and 3d views, and the docs render correctly now. Could you please take a look at the preview deployment and confirm that it resolves the issue on your side? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: circuit preview layout
Cleaned up the container so previews (pcb, schematic, 3d) render consistently
Moved background color logic to the parent
<div>to avoid breaking docsDouble-checked that all previews display correctly and the docs look fine again