Override reconnectOnError in tsed ioredis module

[ygpark80]

Is your feature request related to a problem? Please describe.

There is no way to override 'reconnectOnError' since the internal 'reconnectOnError' always overwrites the one in 'redisOptions'.

tsed/packages/orm/ioredis/src/utils/registerConnectionProvider.ts

Line 67 in 3269a12

reconnectOnError

Describe the solution you'd like

I've been experiencing issues with ioredis in our AWS Lambda-based ts.ed distribution, specifically receiving 'connection is closed' errors from time to time. Many comments including this suggest using 'reconnectOnError', but the ts.ed ioredis distribution hard codes this function.

Describe alternatives you've considered

Perhaps we could change the order to something like the following?

          connection = new Redis({
            lazyConnect: true,
            reconnectOnError,
            ...redisOptions
          } as RedisOptions);

Additional context

No response

Acceptance criteria

No response

[ygpark80]

Oh, one more thing. I'm not sure if this is going to make sense, but I have copied the registerConnectionProvider to my source base and tested the reconnectOnError, but things didn't change. As I was examining the error, since you are forcing the use of lazyConnect: true and making a connection manually, an error may arise from the connect() function, thus rendering the connection useless. Since our lambda is reusing the instance and thus reusing the broken connection, the error continues to occur when ioredis is used. So, I wrapped the connect() function with a try-catch, since the ioredis internal was using connect().catch(noop) when lazyConnect is not used. Since then, an ETIMEDOUT error has occurred once in a while, but the reconnection logic kicked in, and I haven't seen any 5xx errors since then.

i.e.

				try {
					await connection.connect()
					logger.info("Connected to redis database...")
				} catch (error) {
					Sentry.captureException(error)
				}

[github-actions]

🎉 Are you happy?

If you appreciated the support, know that it is free and is carried out on personal time ;)

A support, even a little bit makes a difference for me and continues to bring you answers!

[Romakita]

🎉 This issue has been resolved in version 7.67.7 🎉

The release is available on:

• v7.67.7
• GitHub release

Your semantic-release bot 📦🚀