Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: broken links checker, test on push #1854

Merged
merged 16 commits into from
Apr 25, 2022

Conversation

B8-RX
Copy link
Member

@B8-RX B8-RX commented Apr 12, 2022

Information

Type Breaking change
Feature/Fix/Doc/Chore Yes/No

Todos

  • Tests
  • Coverage
  • Example
  • Documentation

@github-actions
Copy link

Benchmark result

tsed vs express: New benchmarks generated
tsed-koa vs koa: New benchmarks generated.

Note:
Average of all diffs for Ts.ED-* so: (0.15 + 0.14 + 0.12 + 0.12) / 4

Details:

Req/sec Trans/sec Req/sec DIFF Trans/sec DIFF
Ts.ED Express 2102 589.08KB - -
Ts.ED Koa 2552 508.49KB - -
Nest-Express 3478 811.80KB - -
Nest-Fastify 9923 1.67MB - -
Express 3832 0.87MB - -
Express Router 3782 0.86MB - -
Koa 8719 1.46MB - -
Fastify 9492 1.59MB - -

Note:
req/sec DIFF and Trans/sec DIFF is in comparison to the baseline on target branch (master).

@github-actions
Copy link

Benchmark result

tsed vs express: New benchmarks generated
tsed-koa vs koa: New benchmarks generated.

Note:
Average of all diffs for Ts.ED-* so: (0.15 + 0.14 + 0.12 + 0.12) / 4

Details:

Req/sec Trans/sec Req/sec DIFF Trans/sec DIFF
Ts.ED Express 2088 585.30KB - -
Ts.ED Koa 2460 490.07KB - -
Nest-Express 3423 798.92KB - -
Nest-Fastify 9985 1.68MB - -
Express 3833 0.87MB - -
Express Router 3751 0.86MB - -
Koa 8552 1.44MB - -
Fastify 10981 1.84MB - -

Note:
req/sec DIFF and Trans/sec DIFF is in comparison to the baseline on target branch (master).

@Romakita
Copy link
Collaborator

@sofianeSghiouar Ce qu'on voit c'est que sans le récursive on fait juste le controle de la home page :/ C'est dommage. Faudrait trouver un moyen de faire un controle sur les pages de documentation et tutorials à minima.

@Romakita
Copy link
Collaborator

Romakita commented Apr 14, 2022

@sofianeSghiouar Pour l'instant ca ne rempli pas les critères d'acceptances. Essai de voir si tu peux trouver une alternative plus rapide et complète. Il existe plusieurs outils qui check les liens morts sur un site avec github action ^^.

@B8-RX
Copy link
Member Author

B8-RX commented Apr 14, 2022

@sofianeSghiouar Pour l'instant ca ne rempli pas les critères d'acceptances. Essai de voir si tu peux trouver une alternative plus rapide et complète. Il existe plusieurs outils qui check les liens morts sur un site avec github action ^^.

En effet ça ne fait pas le job ^^, je cherche une autre alternative

test link checker on repo

source: https://github.com/lycheeverse/lychee-action

remove repository_dispatch and workflow_dispatch
test link checker on repo

source: https://github.com/lycheeverse/lychee-action

remove repository_dispatch and workflow_dispatch
@github-actions
Copy link

Benchmark result

tsed vs express: New benchmarks generated
tsed-koa vs koa: New benchmarks generated.

Note:
Average of all diffs for Ts.ED-* so: (0.15 + 0.14 + 0.12 + 0.12) / 4

Details:

Req/sec Trans/sec Req/sec DIFF Trans/sec DIFF
Ts.ED Express 2044 572.97KB - -
Ts.ED Koa 2463 490.69KB - -
Nest-Express 3271 763.54KB - -
Nest-Fastify 8395 1.41MB - -
Express 3681 859.13KB - -
Express Router 3550 828.62KB - -
Koa 9535 1.60MB - -
Fastify 10542 1.77MB - -

Note:
req/sec DIFF and Trans/sec DIFF is in comparison to the baseline on target branch (master).

@Romakita
Copy link
Collaborator

Good job. Ca semble etre mieux non?

@B8-RX B8-RX closed this Apr 21, 2022
@B8-RX B8-RX reopened this Apr 21, 2022
@github-actions
Copy link

Benchmark result

tsed vs express: New benchmarks generated
tsed-koa vs koa: New benchmarks generated.

Note:
Average of all diffs for Ts.ED-* so: (0.15 + 0.14 + 0.12 + 0.12) / 4

Details:

Req/sec Trans/sec Req/sec DIFF Trans/sec DIFF
Ts.ED Express 1471 412.16KB - -
Ts.ED Koa 1804 359.31KB - -
Nest-Express 2233 521.14KB - -
Nest-Fastify 5301 0.89MB - -
Express 2470 576.55KB - -
Express Router 2404 561.07KB - -
Koa 5140 0.86MB - -
Fastify 5693 0.96MB - -

Note:
req/sec DIFF and Trans/sec DIFF is in comparison to the baseline on target branch (master).

@github-actions
Copy link

Benchmark result

tsed vs express: New benchmarks generated
tsed-koa vs koa: New benchmarks generated.

Note:
Average of all diffs for Ts.ED-* so: (0.15 + 0.14 + 0.12 + 0.12) / 4

Details:

Req/sec Trans/sec Req/sec DIFF Trans/sec DIFF
Ts.ED Express 2100 588.45KB - -
Ts.ED Koa 2524 502.89KB - -
Nest-Express 3343 780.32KB - -
Nest-Fastify 8474 1.42MB - -
Express 3742 0.85MB - -
Express Router 3679 858.58KB - -
Koa 9933 1.67MB - -
Fastify 10964 1.84MB - -

Note:
req/sec DIFF and Trans/sec DIFF is in comparison to the baseline on target branch (master).

@github-actions
Copy link

Benchmark result

tsed vs express: New benchmarks generated
tsed-koa vs koa: New benchmarks generated.

Note:
Average of all diffs for Ts.ED-* so: (0.15 + 0.14 + 0.12 + 0.12) / 4

Details:

Req/sec Trans/sec Req/sec DIFF Trans/sec DIFF
Ts.ED Express 2820 790.50KB - -
Ts.ED Koa 3239 645.23KB - -
Nest-Express 4540 1.03MB - -
Nest-Fastify 13795 2.32MB - -
Express 4975 1.13MB - -
Express Router 4881 1.11MB - -
Koa 13233 2.22MB - -
Fastify 14402 2.42MB - -

Note:
req/sec DIFF and Trans/sec DIFF is in comparison to the baseline on target branch (master).

@github-actions
Copy link

Benchmark result

tsed vs express: New benchmarks generated
tsed-koa vs koa: New benchmarks generated.

Note:
Average of all diffs for Ts.ED-* so: (0.15 + 0.14 + 0.12 + 0.12) / 4

Details:

Req/sec Trans/sec Req/sec DIFF Trans/sec DIFF
Ts.ED Express 1682 471.29KB - -
Ts.ED Koa 2022 402.77KB - -
Nest-Express 2692 628.34KB - -
Nest-Fastify 8398 1.41MB - -
Express 3044 710.45KB - -
Express Router 3012 703.06KB - -
Koa 7045 1.18MB - -
Fastify 8966 1.50MB - -

Note:
req/sec DIFF and Trans/sec DIFF is in comparison to the baseline on target branch (master).

@github-actions
Copy link

Benchmark result

tsed vs express: New benchmarks generated
tsed-koa vs koa: New benchmarks generated.

Note:
Average of all diffs for Ts.ED-* so: (0.15 + 0.14 + 0.12 + 0.12) / 4

Details:

Req/sec Trans/sec Req/sec DIFF Trans/sec DIFF
Ts.ED Express 2095 587.25KB - -
Ts.ED Koa 2524 502.80KB - -
Nest-Express 3392 791.64KB - -
Nest-Fastify 8601 1.44MB - -
Express 3756 0.86MB - -
Express Router 3701 863.89KB - -
Koa 10152 1.70MB - -
Fastify 10658 1.79MB - -

Note:
req/sec DIFF and Trans/sec DIFF is in comparison to the baseline on target branch (master).

@github-actions
Copy link

Benchmark result

tsed vs express: New benchmarks generated
tsed-koa vs koa: New benchmarks generated.

Note:
Average of all diffs for Ts.ED-* so: (0.15 + 0.14 + 0.12 + 0.12) / 4

Details:

Req/sec Trans/sec Req/sec DIFF Trans/sec DIFF
Ts.ED Express 2099 588.43KB - -
Ts.ED Koa 2513 500.54KB - -
Nest-Express 3373 787.34KB - -
Nest-Fastify 8573 1.44MB - -
Express 3737 0.85MB - -
Express Router 3614 843.39KB - -
Koa 8638 1.45MB - -
Fastify 9646 1.62MB - -

Note:
req/sec DIFF and Trans/sec DIFF is in comparison to the baseline on target branch (master).

@B8-RX
Copy link
Member Author

B8-RX commented Apr 22, 2022

The link checker is now configured to run once a week, i have configured it to run every Sunday at 1h23 AM (UTC+2) :)

@github-actions
Copy link

Benchmark result

tsed vs express: New benchmarks generated
tsed-koa vs koa: New benchmarks generated.

Note:
Average of all diffs for Ts.ED-* so: (0.15 + 0.14 + 0.12 + 0.12) / 4

Details:

Req/sec Trans/sec Req/sec DIFF Trans/sec DIFF
Ts.ED Express 2053 575.52KB - -
Ts.ED Koa 2477 493.36KB - -
Nest-Express 3354 782.93KB - -
Nest-Fastify 10137 1.70MB - -
Express 3707 865.23KB - -
Express Router 3607 841.90KB - -
Koa 9604 1.61MB - -
Fastify 10446 1.75MB - -

Note:
req/sec DIFF and Trans/sec DIFF is in comparison to the baseline on target branch (master).

@Romakita Romakita merged commit 016edf4 into production Apr 25, 2022
@Romakita Romakita deleted the ci-add-broken-link-checker-github-action branch April 25, 2022 08:15
@Romakita
Copy link
Collaborator

🎉 This PR is included in version 6.114.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Romakita
Copy link
Collaborator

🎉 This PR is included in version 7.0.0-beta.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants