Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add eta engine #2557

Open
wants to merge 2 commits into
base: production
Choose a base branch
from
Open

Conversation

beatyt
Copy link

@beatyt beatyt commented Dec 28, 2023

Information

Type Breaking change
Feature No

Idk if you want this but got it set up and wanted to offer. https://eta.js.org/

Example to use your feature and to improve the documentation after merging your PR:

@Configuration({
  views: {
    root: `${rootDir}/views`,
    viewEngine: "eta",
    extensions: {
      eta: "eta"
    },
    options: {
      /// extra eta options
    }
  }
})

Todos

  • Tests
  • Coverage
  • Example
  • Documentation

@beatyt beatyt marked this pull request as draft December 28, 2023 04:02
@Romakita
Copy link
Collaborator

@beatyt thanks for the PR ;) let’s go for the next step ;)

@beatyt beatyt marked this pull request as ready for review December 29, 2023 02:11
@Romakita
Copy link
Collaborator

Hello @beatyt

You have to update the templating.md file and you new template engine:

https://github.com/tsedio/tsed/blob/production/docs/docs/templating.md

You can also add unit test to cover the code. Take as example this test:

https://github.com/tsedio/tsed/blob/200c84c2303ac7041fa3245cbc793bfe73207f4a/packages/engines/src/components/PugEngine.spec.ts

See you

@Romakita
Copy link
Collaborator

Hey @beatyt
I implemented test and fixed the Eta engine instantiation to be compliant with Ts.ED Configuration :)

It should be ok now :)

@Romakita Romakita force-pushed the production branch 4 times, most recently from b76e7c8 to 9230a2a Compare August 25, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants