Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mikro-orm): add support for mikro-orm v6 #2673

Merged

Conversation

derevnjuk
Copy link
Contributor

@derevnjuk derevnjuk commented Apr 23, 2024

Information

Type Breaking change
Fix No

closes #2630

Summary by CodeRabbit

  • New Features
    • Updated database ORM packages to enhance performance and compatibility.
  • Refactor
    • Revised database context initialization to adapt to updated ORM methods.
  • Tests
    • Adjusted test configurations to align with the latest ORM standards.

@derevnjuk derevnjuk self-assigned this Apr 23, 2024
Copy link

coderabbitai bot commented Apr 23, 2024

Warning

Rate Limit Exceeded

@derevnjuk has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 52 minutes and 0 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between cf2996d and ef167ff.

Walkthrough

This update involves changes to the Mikro-ORM package, focusing on version upgrades and method updates due to deprecations. Key modifications include updating dependencies to newer versions and adapting to the new API methods in both configuration and testing contexts. The changes ensure compatibility with the latest versions of the @mikro-orm/core and @mikro-orm/mongodb packages.

Changes

File Path Change Summary
.../mikro-orm/package.json Updated @mikro-orm/core and @mikro-orm/mongodb from 5.9.8 to 6.2.2.
.../src/services/MikroOrmContext.spec.ts Changed createAsync to create in test method call.
.../src/services/MikroOrmContext.ts Replaced deprecated createAsync with create in RequestContext. Added compatibility check.
.../test/integration.spec.ts Replaced object literals with defineConfig for MikroORM settings.

🐰✨
Hop, hop, hop in the code,
Where the versions leap and old methods elope.
A tiny tweak here, a new line there,
Smooth and sleek, the code does care.
Cheers to updates, in the moonlit grove,
Signed, the coding rabbit with love. 🌕🌿


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@derevnjuk
Copy link
Contributor Author

@Romakita draft until #2672 is merged.

@derevnjuk derevnjuk force-pushed the fix-#2630/add-support-for-mikro-orm-v6 branch from de26dc7 to 0a39f5c Compare April 23, 2024 17:53
@derevnjuk derevnjuk requested a review from Romakita April 23, 2024 17:53
@derevnjuk derevnjuk marked this pull request as ready for review April 23, 2024 17:53
@derevnjuk derevnjuk force-pushed the fix-#2630/add-support-for-mikro-orm-v6 branch from 0a39f5c to ef167ff Compare April 23, 2024 17:56
@derevnjuk derevnjuk merged commit 99e1caa into tsedio:production Apr 23, 2024
15 checks passed
@derevnjuk derevnjuk deleted the fix-#2630/add-support-for-mikro-orm-v6 branch April 23, 2024 18:09
@Romakita
Copy link
Collaborator

🎉 This PR is included in version 7.67.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for MikroORM v6
2 participants