Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(swagger): add missing explicit extension swagger-ui-dist/absolute-path import #2722

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

Romakita
Copy link
Collaborator

@Romakita Romakita commented Jun 8, 2024

Information

The migration to full ESM for the Ts.ED repository is in progress. Latest release has switched the code builder to replace automatically __dirname to import.meta.dirname. But I missed to add explicit extension for external library. This PR fix that.

Information

Type Breaking change
Fix No

…-path import

The migration to full ESM for the Ts.ED repository is in progress. latest release has switched the code builder to replace automatically __dirname to import.meta.dirname. But I missed to add explicit extension for external library. This PR fix that.
@Romakita Romakita merged commit d8feb1c into production Jun 8, 2024
2 of 4 checks passed
@Romakita Romakita deleted the fix-esm-migration-issue branch June 8, 2024 08:55
@Romakita
Copy link
Collaborator Author

Romakita commented Jun 8, 2024

🎉 This PR is included in version 7.71.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Jun 8, 2024

Benchmarks

  • Machine: linux x64 | 4 vCPUs | 15.6GB Mem
  • Node: v18.20.3
  • Run: Sat Jun 08 2024 09:06:14 GMT+0000 (Coordinated Universal Time)
  • Method: autocannon -c 100 -d 10 -p 10 localhost:3000 (two rounds; one to warm-up, one to measure)
Version Router Requests/s Latency Throughput/Mb
koa 2.13.4 33441.6 29.39 5.96
tsed-koa 7.71.0 12042.5 82.31 10.20
express 4.19.2 10568.0 93.61 1.88
express-injector 4.19.2 9788.2 101.30 2.23
nest 8.4.3 9785.6 101.34 2.35
tsed-express 7.71.0 8553.1 115.89 1.57
express-morgan 4.19.2 5651.8 175.12 1.01
fastify-big-json 3.29.4 N/A N/A N/A
fastify-injector 3.29.4 N/A N/A N/A
fastify 3.29.4 N/A N/A N/A
nest-fastify 8.4.3 N/A N/A N/A

Explanation

The benchmark shows a performance difference between the frameworks. We note that Ts.ED is often last. In fact, Ts.ED uses features useful to a production application which reduce its performance.

For example, Ts.ED initializes a sandbox (async_hook) for each request in order to work in an isolated context if necessary.
It also initializes the elements necessary for monitoring requests in a log manager.

All this at a necessary cost that reflects the reality of a production application ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant