Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform-serverless): detect lambda event type to map http respo… #2755

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

Romakita
Copy link
Collaborator

…nse when it's only necessary

Information

Type Breaking change
Feature No

Improve support on platform-serverless package. Now Ts.ED detect if the lambda is an APIGatewayEvent (or http event like) and map ServerlessResponse to a valid AWS response. Otherwise, Ts.ED return the raw response from the endpoint.

Solve issue with Lambda Authorizer and other kind of AWS event.

Todos

  • Tests
  • Coverage
  • Example
  • Documentation

Copy link

Benchmarks

  • Machine: linux x64 | 4 vCPUs | 15.6GB Mem
  • Node: v18.20.3
  • Run: Wed Jul 17 2024 07:42:22 GMT+0000 (Coordinated Universal Time)
  • Method: autocannon -c 100 -d 10 -p 10 localhost:3000 (two rounds; one to warm-up, one to measure)
Version Router Requests/s Latency Throughput/Mb
koa 2.13.4 33509.1 29.31 5.98
tsed-koa 7.75.5 11787.3 84.06 9.98
express 4.19.2 10174.2 97.48 1.81
express-injector 4.19.2 9607.1 103.28 2.19
nest 8.4.3 9532.0 104.01 2.29
tsed-express 7.75.5 8390.4 118.02 1.54
express-morgan 4.19.2 5583.8 177.34 1.00
fastify-big-json 3.29.4 N/A N/A N/A
fastify-injector 3.29.4 N/A N/A N/A
fastify 3.29.4 N/A N/A N/A
nest-fastify 8.4.3 N/A N/A N/A

Explanation

The benchmark shows a performance difference between the frameworks. We note that Ts.ED is often last. In fact, Ts.ED uses features useful to a production application which reduce its performance.

For example, Ts.ED initializes a sandbox (async_hook) for each request in order to work in an isolated context if necessary.
It also initializes the elements necessary for monitoring requests in a log manager.

All this at a necessary cost that reflects the reality of a production application ;)

@Romakita Romakita merged commit 1f16ae5 into production Jul 17, 2024
15 checks passed
@Romakita Romakita deleted the feat-serverless-events-response-adapter branch July 17, 2024 08:01
@Romakita
Copy link
Collaborator Author

🎉 This PR is included in version 7.76.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant