Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autoinjectable with many args #2807

Merged
merged 2 commits into from
Aug 31, 2024

Conversation

Romakita
Copy link
Collaborator

Information

Type Breaking change
Fix No

Usage example

@AutoInjectable()
      class Test {
        constructor(
          public items: string[],
          public group: string,
          @Inject() logger?: Logger
        ) {
          expect(items).toEqual(["item1", "item2", "item3"]);
          expect(group).toBe("group");
          expect(logger).toBeInstanceOf(Logger);
        }
      }

      new Test(["item1", "item2", "item3"], "group");

Todos

  • Tests
  • Coverage
  • Example
  • Documentation

@Romakita Romakita merged commit b224666 into production Aug 31, 2024
13 of 14 checks passed
@Romakita Romakita deleted the fix-autoinjectable-with-many-args branch August 31, 2024 18:39
@Romakita
Copy link
Collaborator Author

🎉 This PR is included in version 7.82.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants