Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow targets contain inline bodies similar to shell "here tag" #148

Closed
wants to merge 2 commits into from

Conversation

coxx
Copy link

@coxx coxx commented Sep 22, 2015

It allows targets to have bodies inline (instead of path to a file) as follows:

POST http://foo.bar/
Content-Type: application/json; charset=utf-8
@<<BODY
{
    "one": 1,
    "two": 2
}
BODY

Where BODY is arbitrary tag.

I understand that the patch does not add cleanliness to the target generator code but if idea and feature is OK I'll clean and refactor it in the next step.

@tsenart
Copy link
Owner

tsenart commented Sep 23, 2015

The idea is good, thanks! But I feel the refactor needs to happen before, not after this feature.

@ifraixedes
Copy link

My understanding is that the refactor, you're talking about, refers to #141

@missedone
Copy link

@tsenart , do you have any plan on the refactoring ticket #141, otherwise, looks like any target relate changes will be blocked until the refactoring done?

@tsenart
Copy link
Owner

tsenart commented Nov 9, 2016

@missedone: Yeah, just didn't find time to do it.

@tsenart
Copy link
Owner

tsenart commented May 18, 2018

Superseded by #260

@tsenart tsenart closed this May 18, 2018
@tsenart tsenart mentioned this pull request Jun 29, 2018
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants