Rebase of errors-are-fine #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
reviewed
Oct 21, 2022
|
|
||
|
|
||
| # local method table for device functions | ||
| @static if isdefined(Base.Experimental, Symbol("@overlay")) |
There was a problem hiding this comment.
Top-level @static is useless (and I think you're missing the end?)
There was a problem hiding this comment.
No, the end is fine, it's just 4 lines below, but indentation of the whole file is off, which confused me
There was a problem hiding this comment.
Those @statics were present in CUDA.jl so I just copied them
|
Ok, so now we just need to figure out what in here is causing the dynamic dispatch / |
Merged
|
Ooh, integration tests pass on Nightly now, that's new! |
|
@gbaraldi, I'm curious why you closed this. Given that it looks like it works on Julia v1.9, this'd be a nice feature to have. |
|
Great news! Thanks for the update. I see it now. This will be fun to play with. |
|
Oh yeah, superseded by #97 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I messed up when merging, Probably because the commits were the same, so the revertsa applied.
This looks fine now, but there might be something wrong