Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReferenceError in init-ring-mqtt #663

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

brian-mcnamara
Copy link
Contributor

Issue when initializing which results in the error:

Saving state file /data/ring-state.json failed with error:
ReferenceError: systemId is not defined
    at main (file:///app/ring-mqtt/init-ring-mqtt.js:83:47)

Issue when initializing which results in the error:
```
Saving state file /data/ring-state.json failed with error:
ReferenceError: systemId is not defined
    at main (file:///app/ring-mqtt/init-ring-mqtt.js:83:47)
```
main()
Copy link
Contributor Author

@brian-mcnamara brian-mcnamara Jul 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github edit, I can add the new line back if desired.

@tsightler tsightler changed the base branch from main to dev July 6, 2023 01:36
@tsightler
Copy link
Owner

Thanks for the PR. I actually caught this about a week ago and fixed it in my local instance, but haven't pushed those changes to the dev branch yet. Since you went through the trouble to submit a PR, I'll merge it. Thanks!

@tsightler tsightler merged commit b4ddf7e into tsightler:dev Jul 6, 2023
@brian-mcnamara brian-mcnamara deleted the patch-1 branch July 6, 2023 02:48
@brian-mcnamara
Copy link
Contributor Author

Thanks! I figured it was probably known, but it was easy enough to fix and submit.
And thank you for all your work on this project, it's been a great (and easy) integration between ring and HA.

@Scope666
Copy link

Scope666 commented Jul 6, 2023

I'll second that, this is one of my favorite integrations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants