Use oldest-supported-numpy in wheel building #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
==========================================
- Coverage 99.70% 98.37% -1.33%
==========================================
Files 7 8 +1
Lines 1000 1166 +166
Branches 64 64
==========================================
+ Hits 997 1147 +150
- Misses 1 17 +16
Partials 2 2
Continue to review full report at Codecov.
|
.github/workflows/wheels.yml
Outdated
| @@ -24,10 +24,13 @@ jobs: | |||
| env: | |||
| PYTHON: "py -${{ matrix.python }}-${{ matrix.wordsize }}" | |||
| shell: bash | |||
| # Instead of letting setup.py install a newer numpy we install it here | |||
| # using the oldest supported version for ABI compatibility | |||
| run: | | |||
| set -ex | |||
| ${PYTHON} -m pip install --upgrade pip | |||
| ${PYTHON} -m pip install setuptools wheel cython | |||
There was a problem hiding this comment.
Does cython pull in numpy? If so, maybe better to install oldest-supported-numpy first?
|
@jeromekelleher Removed cython - should be ready to go. |
|
Great, thanks @benjeffery. Let's give it a go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #129