-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use oldest-supported-numpy in wheel building #131
Conversation
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
==========================================
- Coverage 99.70% 98.37% -1.33%
==========================================
Files 7 8 +1
Lines 1000 1166 +166
Branches 64 64
==========================================
+ Hits 997 1147 +150
- Misses 1 17 +16
Partials 2 2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - one minor comment
.github/workflows/wheels.yml
Outdated
@@ -24,10 +24,13 @@ jobs: | |||
env: | |||
PYTHON: "py -${{ matrix.python }}-${{ matrix.wordsize }}" | |||
shell: bash | |||
# Instead of letting setup.py install a newer numpy we install it here | |||
# using the oldest supported version for ABI compatibility | |||
run: | | |||
set -ex | |||
${PYTHON} -m pip install --upgrade pip | |||
${PYTHON} -m pip install setuptools wheel cython |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does cython pull in numpy? If so, maybe better to install oldest-supported-numpy first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed cython
@jeromekelleher Removed cython - should be ready to go. |
Great, thanks @benjeffery. Let's give it a go! |
Fixes #129