Prevent contains from borrowing an array
#189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjeffery
force-pushed
the
fix_contains_borrows
branch
2 times, most recently
from
8f3f8d1
to
df5c555
Compare
Codecov Report
@@ Coverage Diff @@
## main #189 +/- ##
=======================================
Coverage 99.77% 99.77%
=======================================
Files 12 12
Lines 876 876
Branches 136 136
=======================================
Hits 874 874
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
jeromekelleher
approved these changes
Mar 4, 2022
benjeffery
force-pushed
the
fix_contains_borrows
branch
from
df5c555
to
9174d04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
KAS_GET_TAKES_OWNERSHIPwas specified,containsborrowed the array as it usedget. This refactors to not useget.