Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise error when calculating ARG likelihood on simplified tree seqs #2123

Closed
hyanwong opened this issue Nov 12, 2022 · 1 comment · Fixed by #2124
Closed

Raise error when calculating ARG likelihood on simplified tree seqs #2123

hyanwong opened this issue Nov 12, 2022 · 1 comment · Fixed by #2124
Labels
enhancement

Comments

@hyanwong
Copy link
Member

hyanwong commented Nov 12, 2022 •
edited
Loading

I think it isn't meaningful to run log_arg_likelihood on a simplified TS, but it is currently possible to do so. Maybe if there is >1 tree, but no RE nodes in the TS, we should error out when running log_arg_likelihood?
@jeromekelleher
Copy link
Member

Could do easily enough i guess.

hyanwong added a commit to hyanwong/msprime that referenced this issue Nov 16, 2022
@hyanwong
Check for tree seqs without recombination nodes
6ea7279 
Fixes tskit-dev#2123
@hyanwong hyanwong mentioned this issue Nov 16, 2022
Merged
hyanwong added a commit to hyanwong/msprime that referenced this issue Nov 16, 2022
@hyanwong
Check for tree seqs without recombination nodes
c50f8ea 
Fixes tskit-dev#2123
hyanwong added a commit to hyanwong/msprime that referenced this issue Nov 16, 2022
@hyanwong
Check for tree seqs without recombination nodes
f5a6155 
Fixes tskit-dev#2123
AdminBot-tskit pushed a commit to hyanwong/msprime that referenced this issue Nov 16, 2022
@hyanwong @mergify
Check for tree seqs without recombination nodes
c54549b 
Fixes tskit-dev#2123
@mergify mergify bot closed this as completed in #2124 Nov 16, 2022
mergify bot pushed a commit that referenced this issue Nov 16, 2022
@hyanwong @mergify
Check for tree seqs without recombination nodes
0cef092 
Fixes #2123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check for tree seqs without recombination nodes hyanwong/msprime
2 participants
@jeromekelleher @hyanwong