Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance regression for replication #608

Closed
jeromekelleher opened this issue Sep 20, 2018 · 2 comments
Closed

Performance regression for replication #608

jeromekelleher opened this issue Sep 20, 2018 · 2 comments
Milestone
Release 0.6.2

Comments

@jeromekelleher
Copy link
Member

There is a significant performance regression since version 0.5.0 when running multiple replicate simulations. This is caused by a new low-level Simulator instance being created for every replicate.

Many thanks to @joaks1 for reporting this.
@jeromekelleher jeromekelleher added this to the Release 0.6.2 milestone Sep 20, 2018
jeromekelleher added a commit to mcveanlab/msprime that referenced this issue Sep 23, 2018
@jeromekelleher
Fix replication performance regression.
79acc45 
Closes tskit-dev#608
@jeromekelleher jeromekelleher mentioned this issue Sep 23, 2018
Merged
@jeromekelleher
Copy link
Member Author

Reopened after earlier fix caused a bug in migration rates #611.

jeromekelleher added a commit to mcveanlab/msprime that referenced this issue Nov 21, 2018
@jeromekelleher
Fixed performance regression.
6396ccf 
Fixed bug in C-level simulator reset in which the start time for
populations was set incorrectly.

Closes tskit-dev#608
@jeromekelleher jeromekelleher mentioned this issue Nov 21, 2018
Merged
@jeromekelleher
Copy link
Member Author

The fix for this has been released in 0.6.2 @joaks1; thanks again for the bug report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 0.6.2
Development

No branches or pull requests
1 participant
@jeromekelleher