Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move reference_sequence to metadata? #147

Closed
petrelharp opened this issue Feb 22, 2021 · 2 comments
Closed

move reference_sequence to metadata? #147

petrelharp opened this issue Feb 22, 2021 · 2 comments
Milestone

Comments

@petrelharp
Copy link
Contributor

Some of the ugliness we currently have has to do with preserving the reference sequence, which recall is stored as a separate column in the kastore. However, if it was just top-level metadata, then we'd get it passed around for free, and we could get rid of a number of ugly things, for instance, the need for a wrapper on simplify. However, this would require a change in how SLiM writes it out as well.

However, maybe we're just going to put support for reference sequences into tskit; if so, we should just wait for that. If not, we should definitely move it to metadata.

@petrelharp petrelharp added this to the v1.0 milestone Mar 10, 2021
@petrelharp
Copy link
Contributor Author

Relies on MesserLab/SLiM#180

@benjeffery
Copy link
Member

Discussion of ref seq in tskit is here: tskit-dev/tskit#146 It seems overdue to add tskit support for the reference sequence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants