Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sequence length to be specified in sd.subset #681

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

hyanwong
Copy link
Member

Just hit this bug - I wanted to change the seq length when subsetting, which the docs imply should be possible.

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #681 (b85de9f) into main (4f76b6a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #681   +/-   ##
=======================================
  Coverage   93.10%   93.10%           
=======================================
  Files          17       17           
  Lines        5149     5151    +2     
  Branches      957      958    +1     
=======================================
+ Hits         4794     4796    +2     
  Misses        235      235           
  Partials      120      120           
Flag Coverage Δ
C 93.10% <100.00%> (+<0.01%) ⬆️
python 96.32% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tsinfer/formats.py 98.44% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f76b6a...b85de9f. Read the comment docs.

@hyanwong hyanwong force-pushed the allow-seq-len-setting-subset branch from 2592e72 to 75efd0b Compare June 21, 2022 19:53
Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for messing with kwargs dict here.

tsinfer/formats.py Outdated Show resolved Hide resolved
@hyanwong hyanwong force-pushed the allow-seq-len-setting-subset branch from 75efd0b to b85de9f Compare June 22, 2022 11:26
@mergify mergify bot merged commit 7079672 into tskit-dev:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants