Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move stabilise_node_ordering into eval function #710

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

hyanwong
Copy link
Member

Fixes #709. I guess we don't need to add this to the changelog as it was never documented in the first place?

Fixes tskit-dev#709. I guess we don't need to add this to the changelog as it was never documented in the first place?
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #710 (5ce7fb5) into main (4446741) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #710   +/-   ##
=======================================
  Coverage   93.11%   93.11%           
=======================================
  Files          17       17           
  Lines        5153     5155    +2     
  Branches      959      959           
=======================================
+ Hits         4798     4800    +2     
  Misses        235      235           
  Partials      120      120           
Flag Coverage Δ
C 93.11% <100.00%> (+<0.01%) ⬆️
python 96.33% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tsinfer/eval_util.py 90.47% <100.00%> (+0.23%) ⬆️
tsinfer/inference.py 98.56% <100.00%> (-0.02%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect - much better!

@mergify mergify bot merged commit 69bb8c7 into tskit-dev:main Sep 22, 2022
@hyanwong hyanwong deleted the stabilise_node_ordering branch October 8, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove stabilise_node_ordering option from API
2 participants