Add mask to sgkit SampleData #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #791 +/- ##
==========================================
+ Coverage 93.51% 93.61% +0.10%
==========================================
Files 17 17
Lines 5874 5905 +31
Branches 1051 1063 +12
==========================================
+ Hits 5493 5528 +35
+ Misses 250 246 -4
Partials 131 131
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
benjeffery
force-pushed
the
mask
branch
2 times, most recently
from
4110f47
to
ad93c27
Compare
|
This needs a few more tests before merging. |
benjeffery
force-pushed
the
mask
branch
2 times, most recently
from
521879e
to
726eac6
Compare
Merged
|
Converted back to draft as I'm not 100% sure the haplotype iterator is using the mask - not sure how the tests are passing if it is, but need to check. |
benjeffery
force-pushed
the
mask
branch
2 times, most recently
from
43a545c
to
4cb9fd4
Compare
|
Added all the other arrays that the existing sample data used, including fallbacks for when they are missing. |
jeromekelleher
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #786