Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.11 support #822

Closed
wants to merge 1 commit into from
Closed

Python 3.11 support #822

wants to merge 1 commit into from

Conversation

benjeffery
Copy link
Member

No description provided.

@benjeffery benjeffery marked this pull request as ready for review May 10, 2023 15:12
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #822 (7af2e62) into main (e6f31ec) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #822   +/-   ##
=======================================
  Coverage   87.04%   87.04%           
=======================================
  Files           5        5           
  Lines        1767     1767           
  Branches      310      310           
=======================================
  Hits         1538     1538           
  Misses        140      140           
  Partials       89       89           
Flag Coverage Δ
C 87.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@benjeffery
Copy link
Member Author

I've removed all the version specifications and conda still isn't happy. Will need to look into why.

@benjeffery benjeffery force-pushed the 3.11 branch 2 times, most recently from 1544cab to f9a2156 Compare May 11, 2023 12:16
@benjeffery
Copy link
Member Author

Mamba gives a much better error:

Encountered problems while solving:
  - package numcodecs-0.10.0-py39h5a03fae_0 requires python >=3.9,<3.10.0a0, but none of the providers can be installed

@jeromekelleher
Copy link
Member

Ahhh. Wonder what's going on with numcodecs? They're usually pretty good for this.

@benjeffery
Copy link
Member Author

https://anaconda.org/conda-forge/numcodecs/files seems to show a py3.11 package.

@jeromekelleher
Copy link
Member

Let's just let this one sit for a bit - 3.11 packages aren't crucial for tsinfer here, right?

@hyanwong
Copy link
Member

I agree. 3.10 is perfectly good for the time being.

@benjeffery
Copy link
Member Author

Superseded by #936

@benjeffery benjeffery closed this Jul 19, 2024
@benjeffery benjeffery deleted the 3.11 branch July 19, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants