Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zero copy writing to kastore #2111

Closed
jeromekelleher opened this issue Jan 28, 2022 · 0 comments · Fixed by #2124
Closed

Zero copy writing to kastore #2111

jeromekelleher opened this issue Jan 28, 2022 · 0 comments · Fixed by #2124
Assignees
@benjeffery
Labels
C API Issue is about the C API Performance This issue addresses performance, either runtime or memory
Milestone
C API 1.0

Comments

@jeromekelleher
Copy link
Member

We should now able able to write columns to the kastore without creating an intervening copy using KAS_PUT_BORROWS_ARRAY in kastore 2.0.1.

Should be a simple enough change. It would be good to record the memory profile of writing out a large file here as well, to confirm that we're getting the peak memory usage benefits we expect.
@jeromekelleher jeromekelleher added C API Issue is about the C API Performance This issue addresses performance, either runtime or memory labels Jan 28, 2022
@jeromekelleher jeromekelleher added this to the C API 1.0 milestone Jan 28, 2022
@benjeffery benjeffery mentioned this issue Feb 8, 2022
Merged
@mergify mergify bot closed this as completed in #2124 Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjeffery benjeffery

Labels
C API Issue is about the C API Performance This issue addresses performance, either runtime or memory
Projects
None yet
Milestone
C API 1.0
Development

Successfully merging a pull request may close this issue.

Use KAS_BORROWS_ARRAY benjeffery/tskit
2 participants
@benjeffery @jeromekelleher