New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add table extend method #1287
Add table extend method #1287
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1287 +/- ##
==========================================
- Coverage 93.84% 93.83% -0.02%
==========================================
Files 26 26
Lines 22057 22073 +16
Branches 1006 1005 -1
==========================================
+ Hits 20700 20712 +12
- Misses 1324 1328 +4
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think we should tweak the semantics around num_rows
though.
OK, changes made, will crack on with the other tables. |
2be07f2
to
a4e2f98
Compare
@jeromekelleher Should be good to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice, thanks @benjeffery. One minor simplification we can make.
15fa8a0
to
6ea501d
Compare
Fixes #1271