Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table extend method #1287

Merged
merged 1 commit into from Apr 1, 2021
Merged

Add table extend method #1287

merged 1 commit into from Apr 1, 2021

Conversation

benjeffery
Copy link
Member

@benjeffery benjeffery commented Mar 31, 2021

Fixes #1271

@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #1287 (5a763d5) into main (6782342) will decrease coverage by 0.01%.
The diff coverage is 77.77%.

❗ Current head 5a763d5 differs from pull request most recent head 0755ba5. Consider uploading reports for the commit 0755ba5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1287      +/-   ##
==========================================
- Coverage   93.84%   93.83%   -0.02%     
==========================================
  Files          26       26              
  Lines       22057    22073      +16     
  Branches     1006     1005       -1     
==========================================
+ Hits        20700    20712      +12     
- Misses       1324     1328       +4     
  Partials       33       33              
Flag Coverage Δ
c-tests 92.47% <77.77%> (-0.03%) ⬇️
lwt-tests 92.97% <ø> (ø)
python-c-tests 95.14% <ø> (-0.01%) ⬇️
python-tests 98.86% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
c/tskit/tables.c 90.89% <77.77%> (-0.04%) ⬇️
python/tskit/trees.py 97.89% <0.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6782342...0755ba5. Read the comment docs.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think we should tweak the semantics around num_rows though.

c/tskit/tables.h Outdated Show resolved Hide resolved
c/tskit/tables.h Outdated Show resolved Hide resolved
@benjeffery
Copy link
Member Author

OK, changes made, will crack on with the other tables.

@benjeffery benjeffery force-pushed the extend2 branch 3 times, most recently from 2be07f2 to a4e2f98 Compare March 31, 2021 18:35
@benjeffery benjeffery marked this pull request as ready for review March 31, 2021 18:36
@benjeffery
Copy link
Member Author

@jeromekelleher Should be good to go!

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice, thanks @benjeffery. One minor simplification we can make.

c/tskit/tables.c Show resolved Hide resolved
c/tskit/tables.c Outdated Show resolved Hide resolved
@benjeffery benjeffery force-pushed the extend2 branch 2 times, most recently from 15fa8a0 to 6ea501d Compare April 1, 2021 10:24
@benjeffery benjeffery added the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Apr 1, 2021
@mergify mergify bot merged commit f277006 into tskit-dev:main Apr 1, 2021
@mergify mergify bot removed the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Apr 1, 2021
@benjeffery benjeffery deleted the extend2 branch April 1, 2021 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tsk_X_table_extend method
2 participants