Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time_units enumeration #1832

Merged
merged 1 commit into from Oct 22, 2021
Merged

Conversation

benjeffery
Copy link
Member

Fixes #1772

@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #1832 (9e9251f) into main (631ed78) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 9e9251f differs from pull request most recent head 3840429. Consider uploading reports for the commit 3840429 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1832      +/-   ##
==========================================
- Coverage   93.43%   93.39%   -0.04%     
==========================================
  Files          27       27              
  Lines       24804    24820      +16     
  Branches     1094     1094              
==========================================
+ Hits        23175    23181       +6     
- Misses       1594     1604      +10     
  Partials       35       35              
Flag Coverage Δ
c-tests 92.12% <ø> (-0.08%) ⬇️
lwt-tests 89.14% <ø> (ø)
python-c-tests 94.53% <100.00%> (+<0.01%) ⬆️
python-tests 98.75% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
c/tskit/core.h 100.00% <ø> (ø)
c/tskit/tables.c 90.17% <ø> (-0.13%) ⬇️
python/_tskitmodule.c 91.68% <100.00%> (+<0.01%) ⬆️
python/tskit/__init__.py 100.00% <100.00%> (ø)
python/tskit/drawing.py 99.42% <100.00%> (+<0.01%) ⬆️
python/tskit/trees.py 97.84% <100.00%> (ø)
python/tskit/metadata.py 98.84% <0.00%> (-0.01%) ⬇️
python/tskit/exceptions.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 631ed78...3840429. Read the comment docs.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but maybe we should change the DEFAULT to UNKNOWN?

python/_tskitmodule.c Outdated Show resolved Hide resolved
@jeromekelleher jeromekelleher added the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Oct 22, 2021
@mergify mergify bot merged commit cc9e445 into tskit-dev:main Oct 22, 2021
@mergify mergify bot removed the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add enumeration for time units
2 participants